Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: ui/views/animation/ink_drop_animation_controller_factory_unittest.cc

Issue 1390113006: Added material design mouse hover feedback support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed the InkDropAnimationControllerImpl to destroy its timer when not running. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
diff --git a/ui/views/animation/ink_drop_animation_controller_factory_unittest.cc b/ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
index 6fa3324902810adbb0c37bdfe5383b3945849a72..a00a347a5afc4ef55171cdb4ace925983a3c3ff8 100644
--- a/ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
+++ b/ui/views/animation/ink_drop_animation_controller_factory_unittest.cc
@@ -4,12 +4,17 @@
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
+#include "base/test/test_mock_time_task_runner.h"
+#include "base/test/test_simple_task_runner.h"
+#include "base/thread_task_runner_handle.h"
+#include "base/timer/timer.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/material_design/material_design_controller.h"
#include "ui/base/test/material_design_controller_test_api.h"
#include "ui/compositor/scoped_animation_duration_scale_mode.h"
#include "ui/views/animation/ink_drop_animation_controller.h"
#include "ui/views/animation/ink_drop_animation_controller_factory.h"
+#include "ui/views/animation/ink_drop_animation_controller_impl.h"
#include "ui/views/animation/ink_drop_host.h"
#include "ui/views/animation/ink_drop_state.h"
#include "ui/views/animation/test/test_ink_drop_host.h"
@@ -17,7 +22,8 @@
namespace views {
class InkDropAnimationControllerFactoryTest
- : public testing::TestWithParam<ui::MaterialDesignController::Mode> {
+ : public testing::TestWithParam<
+ testing::tuple<ui::MaterialDesignController::Mode>> {
public:
InkDropAnimationControllerFactoryTest();
~InkDropAnimationControllerFactoryTest();
@@ -31,8 +37,14 @@ class InkDropAnimationControllerFactoryTest
scoped_ptr<InkDropAnimationController> ink_drop_animation_controller_;
private:
+ // Extracts and returns the material design mode from the test parameters.
+ ui::MaterialDesignController::Mode GetMaterialMode() const;
+
scoped_ptr<ui::ScopedAnimationDurationScaleMode> zero_duration_mode_;
+ // Required by base::Timer's.
+ scoped_ptr<base::ThreadTaskRunnerHandle> thread_task_runner_handle_;
+
DISALLOW_COPY_AND_ASSIGN(InkDropAnimationControllerFactoryTest);
};
@@ -42,7 +54,7 @@ InkDropAnimationControllerFactoryTest::InkDropAnimationControllerFactoryTest()
// initialize and cache the mode. This ensures that these tests will run from
// a non-initialized state.
ui::test::MaterialDesignControllerTestAPI::UninitializeMode();
- ui::test::MaterialDesignControllerTestAPI::SetMode(GetParam());
+ ui::test::MaterialDesignControllerTestAPI::SetMode(GetMaterialMode());
ink_drop_animation_controller_.reset(
InkDropAnimationControllerFactory::CreateInkDropAnimationController(
&test_ink_drop_host_)
@@ -52,6 +64,20 @@ InkDropAnimationControllerFactoryTest::InkDropAnimationControllerFactoryTest()
zero_duration_mode_.reset(new ui::ScopedAnimationDurationScaleMode(
ui::ScopedAnimationDurationScaleMode::ZERO_DURATION));
+
+ switch (GetMaterialMode()) {
+ case ui::MaterialDesignController::NON_MATERIAL:
+ break;
+ case ui::MaterialDesignController::MATERIAL_NORMAL:
+ case ui::MaterialDesignController::MATERIAL_HYBRID:
+ // The Timer's used by the InkDropAnimationControllerImpl class require a
+ // base::ThreadTaskRunnerHandle instance.
+ scoped_refptr<base::TestMockTimeTaskRunner> task_runner(
+ new base::TestMockTimeTaskRunner);
+ thread_task_runner_handle_.reset(
+ new base::ThreadTaskRunnerHandle(task_runner));
+ break;
+ }
}
InkDropAnimationControllerFactoryTest::
@@ -59,13 +85,19 @@ InkDropAnimationControllerFactoryTest::
ui::test::MaterialDesignControllerTestAPI::UninitializeMode();
}
+ui::MaterialDesignController::Mode
+InkDropAnimationControllerFactoryTest::GetMaterialMode() const {
+ return testing::get<0>(GetParam());
+}
+
// Note: First argument is optional and intentionally left blank.
// (it's a prefix for the generated test cases)
INSTANTIATE_TEST_CASE_P(
,
InkDropAnimationControllerFactoryTest,
testing::Values(ui::MaterialDesignController::NON_MATERIAL,
- ui::MaterialDesignController::MATERIAL_NORMAL));
+ ui::MaterialDesignController::MATERIAL_NORMAL,
+ ui::MaterialDesignController::MATERIAL_HYBRID));
TEST_P(InkDropAnimationControllerFactoryTest,
VerifyAllInkDropLayersRemovedAfterDestruction) {
@@ -79,6 +111,13 @@ TEST_P(InkDropAnimationControllerFactoryTest, StateIsHiddenInitially) {
ink_drop_animation_controller_->GetInkDropState());
}
+TEST_P(InkDropAnimationControllerFactoryTest, HoveredStateAfterAnimateToState) {
+ ink_drop_animation_controller_->SetHovered(true);
+ ink_drop_animation_controller_->AnimateToState(InkDropState::ACTION_PENDING);
+
+ EXPECT_FALSE(ink_drop_animation_controller_->IsHovered());
+}
+
TEST_P(InkDropAnimationControllerFactoryTest, TypicalQuickAction) {
ink_drop_animation_controller_->AnimateToState(InkDropState::ACTION_PENDING);
ink_drop_animation_controller_->AnimateToState(InkDropState::QUICK_ACTION);
« no previous file with comments | « ui/views/animation/ink_drop_animation_controller_factory.cc ('k') | ui/views/animation/ink_drop_animation_controller_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698