chrome/browser/ui/views/toolbar/toolbar_button.cc - Issue 1390113006: Added material design mouse hover feedback support.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.cc

Issue 1390113006: Added material design mouse hover feedback support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved MouseEntered/Exit() to hover handling in to the ButtonInkDropDelegate. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/toolbar/toolbar_button.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.cc b/chrome/browser/ui/views/toolbar/toolbar_button.cc

index 79f1d633e3082dee29f0cc7c701983daff40ba2e..3e598b0516cb144596d67e3d50321eefce6fbe01 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_button.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_button.cc

@@ -144,6 +144,7 @@ void ToolbarButton::OnMouseExited(const ui::MouseEvent& event) {

// remain in a PUSHED state until the drop down menu closes.

if (state() != STATE_DISABLED && !InDrag() && state() != STATE_PRESSED)

SetState(STATE_NORMAL);

+ UpdateInkDropHoverState();

varkha 2016/01/22 15:45:32 Would this not be taken care by the delegate's OnM

bruthig 2016/01/25 22:39:17 Removed.

}

void ToolbarButton::OnGestureEvent(ui::GestureEvent* event) {

« no previous file with comments | « no previous file | ui/views/animation/button_ink_drop_delegate.h » ('j') | ui/views/animation/ink_drop_animation_controller_impl.h » ('J')