Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 1390113003: Fix some build breaks. (Closed)

Created:
5 years, 2 months ago by Jacob
Modified:
5 years, 2 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some build breaks. Fix test breaks Roll dep forward to fix windows build. Dartium typed js interop work dart repo side of the change. Also tries to get BUG= Committed: https://github.com/dart-lang/sdk/commit/1f9516ba0bb79225f4f5cdb614e20a055960a636

Patch Set 1 #

Patch Set 2 : TBR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -19 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 3 chunks +19 lines, -9 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 chunks +18 lines, -8 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Jacob
TBR
5 years, 2 months ago (2015-10-07 20:46:49 UTC) #2
Jacob
5 years, 2 months ago (2015-10-07 20:47:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1f9516ba0bb79225f4f5cdb614e20a055960a636 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698