Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1390073006: Add cr-policy-network-indicator to internet pages (Closed)

Created:
5 years, 2 months ago by stevenjb
Modified:
5 years, 2 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_521791_network_indicators_c3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add cr-policy-network-indicator to internet pages This CL: * Adds cr-policy-network-indicator to internet pages * Disables some controls based on policy * Fixes some RTL issues in related CSS BUG=521791 Committed: https://crrev.com/193da9609b11350a34ed6125c745bf0eabb239fa Cr-Commit-Position: refs/heads/master@{#355622}

Patch Set 1 #

Total comments: 11

Patch Set 2 : Rebase #

Patch Set 3 : Formatting fixes #

Messages

Total messages: 9 (3 generated)
stevenjb
https://codereview.chromium.org/1390073006/diff/1/chrome/browser/resources/settings/internet_page/network_property_list.css File chrome/browser/resources/settings/internet_page/network_property_list.css (right): https://codereview.chromium.org/1390073006/diff/1/chrome/browser/resources/settings/internet_page/network_property_list.css#newcode8 chrome/browser/resources/settings/internet_page/network_property_list.css:8: margin: 0 5px 5px 0; RTL in this CSS ...
5 years, 2 months ago (2015-10-07 19:37:04 UTC) #2
michaelpg
lgtm with minor fixes https://codereview.chromium.org/1390073006/diff/1/chrome/browser/resources/settings/internet_page/internet_detail_page.html File chrome/browser/resources/settings/internet_page/internet_detail_page.html (right): https://codereview.chromium.org/1390073006/diff/1/chrome/browser/resources/settings/internet_page/internet_detail_page.html#newcode73 chrome/browser/resources/settings/internet_page/internet_detail_page.html:73: property="[[getManagedAutoConnect_(networkProperties)]]"> wrong indent https://codereview.chromium.org/1390073006/diff/1/chrome/browser/resources/settings/internet_page/network_property_list.js File ...
5 years, 2 months ago (2015-10-10 06:01:32 UTC) #3
stevenjb
https://codereview.chromium.org/1390073006/diff/1/chrome/browser/resources/settings/internet_page/internet_detail_page.html File chrome/browser/resources/settings/internet_page/internet_detail_page.html (right): https://codereview.chromium.org/1390073006/diff/1/chrome/browser/resources/settings/internet_page/internet_detail_page.html#newcode73 chrome/browser/resources/settings/internet_page/internet_detail_page.html:73: property="[[getManagedAutoConnect_(networkProperties)]]"> On 2015/10/10 06:01:32, michaelpg wrote: > wrong indent ...
5 years, 2 months ago (2015-10-22 19:08:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390073006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390073006/40001
5 years, 2 months ago (2015-10-22 19:09:15 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-22 19:55:34 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 19:57:02 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/193da9609b11350a34ed6125c745bf0eabb239fa
Cr-Commit-Position: refs/heads/master@{#355622}

Powered by Google App Engine
This is Rietveld 408576698