Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 1390073004: Revert of [turbofan] Add initial support for global specialization. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@AstGraphBuilder
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Add initial support for global specialization. (patchset #4 id:60001 of https://codereview.chromium.org/1387393002/ ) Reason for revert: Breaks GC stress: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/1984/steps/Bisect%20c5528ac1.Retry/logs/regress-crbug-450960 Original issue's description: > [turbofan] Add initial support for global specialization. > > Introduce a new JSGlobalSpecialization advanced reducer that runs > during the initial inlining and context specialization, and specializes > the graph to the globals of the native context. Currently we assume > that we do not inline cross native context, but long-term we will grab > the global object from the JSLoadGlobal/JSStoreGlobal feedback (with the > new global load/store ICs that are currently in the workings), and then > this whole specialization will be fully compositional even across > cross-context inlining. > > Note that we cannot really handle most of the stores to global object > property cells because TurboFan doesn't have a mechanism to enforce > certain representations. Also note that we cannot yet fully benefit > from the type feedback collected on the global object property cells, > because the type system cannot deal with maps in a reasonable way. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel > R=jarin@chromium.org > BUG=v8:4470 > LOG=n > > Committed: https://crrev.com/6fbf7903f94924ea066af481719898bd9667b6eb > Cr-Commit-Position: refs/heads/master@{#31139} TBR=jarin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4470 Committed: https://crrev.com/84065c5f1e5a74439f1c10813321625855676ef3 Cr-Commit-Position: refs/heads/master@{#31144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -388 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler.h View 2 chunks +8 lines, -17 lines 0 comments Download
M src/compiler.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M src/compiler/access-builder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-context-specialization.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D src/compiler/js-global-specialization.h View 1 chunk +0 lines, -82 lines 0 comments Download
D src/compiler/js-global-specialization.cc View 1 chunk +0 lines, -240 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-compiler.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/mjsunit/call-runtime-tail.js View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of [turbofan] Add initial support for global specialization.
5 years, 2 months ago (2015-10-07 11:41:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390073004/1
5 years, 2 months ago (2015-10-07 11:41:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 11:42:18 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 11:42:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84065c5f1e5a74439f1c10813321625855676ef3
Cr-Commit-Position: refs/heads/master@{#31144}

Powered by Google App Engine
This is Rietveld 408576698