Trace FrameTreeNode Snapshots

content/browser/frame_host/traced_frame_tree.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/trace_event/trace_event_impl.h"
+#include "base/values.h"
+#include "content/common/content_export.h"
+#include "url/gurl.h"
+
+namespace content {
+
+class FrameTree;
+
+class CONTENT_EXPORT TracedFrameTree :

[clamy, 2015/10/12 09:31:06]

It would also be nice to have a comment to explain what that class is doing :).

[benjhayden, 2015/10/13 00:22:21]

Done.

+  public base::trace_event::ConvertableToTraceFormat {
+ public:
+  static scoped_refptr<TracedFrameTree> Create(const FrameTree& tree);
+
+  void AppendAsTraceFormat(std::string* out) const override;
+
+ private:
+  explicit TracedFrameTree(const FrameTree& tree);
+  ~TracedFrameTree() override;
+
+  scoped_ptr<base::DictionaryValue> value_;
+
+  DISALLOW_COPY_AND_ASSIGN(TracedFrameTree);
+};
+
+}

[clamy, 2015/10/12 09:31:06]

Add "// content" after the { (see example for an unnamed namespace:
https://www.chromium.org/developers/coding-style#TOC-Unnamed-Namespaces).

[benjhayden, 2015/10/13 00:22:21]

Done.