Trace FrameTreeNode Snapshots

content/browser/frame_host/traced_frame_tree_node.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.

[nasko, 2016/03/02 00:20:20]

Same here, 2016.

[benjhayden, 2016/03/02 18:53:03]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/frame_host/traced_frame_tree_node.h"
+
+#include "base/command_line.h"
+#include "base/json/json_writer.h"
+#include "base/strings/stringprintf.h"
+#include "content/browser/frame_host/frame_tree.h"
+#include "content/public/common/content_switches.h"
+#include "url/gurl.h"
+
+namespace content {
+
+TracedFrameTreeNode::TracedFrameTreeNode(const FrameTreeNode& node)
+    : parentNodeId_(-1),
+      url_(node.current_url().spec()),
+      processId_(-1),
+      routingId_(-1) {
+  FrameTreeNode* parent = node.parent();
+  if (parent)
+    parentNodeId_ = parent->frame_tree_node_id();
+
+  RenderFrameHostImpl* current_frame_host = node.current_frame_host();
+  if (current_frame_host) {

[nasko, 2016/03/02 00:20:20]

There should always be a current_frame_host.

[benjhayden, 2016/03/02 18:53:03]

Done.

+    processId_ = current_frame_host->GetProcess()->GetHandle();
+    routingId_ = current_frame_host->GetRoutingID();
+  }
+}
+
+TracedFrameTreeNode::~TracedFrameTreeNode() {
+}
+
+void TracedFrameTreeNode::AppendAsTraceFormat(std::string* out) const {
+  scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
+
+  if (parentNodeId_ >= 0) {
+    scoped_ptr<base::DictionaryValue> ref(new base::DictionaryValue());
+    ref->SetString("id_ref", base::StringPrintf("0x%x", parentNodeId_));
+    ref->SetString("scope", "FrameTreeNode");
+    value->Set("parent", std::move(ref));
+  }
+
+  if (routingId_ >= 0) {

[nasko, 2016/03/02 00:20:20]

routing_id != MSG_ROUTING_NONE is more correct comparison. On the other hand,
this should never be the case, so at most put a DCHECK in the constructor to
ensure the routing id is not NONE.

[benjhayden, 2016/03/02 18:53:03]

Done.

+    scoped_ptr<base::DictionaryValue> ref(new base::DictionaryValue());
+    ref->SetInteger("pid_ref", processId_);
+    ref->SetString("id_ref", base::StringPrintf("0x%x", routingId_));
+    ref->SetString("scope", "RenderFrame");
+    value->Set("RenderFrame", std::move(ref));
+  }
+
+  value->SetString("url", url_);
+  std::string tmp;
+  base::JSONWriter::Write(*value, &tmp);
+  *out += tmp;
+}
+
+}  // content