Use simple/fast macro version of MinMax in JS

src/harmony-atomics.js

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, utils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
 // -------------------------------------------------------------------
 // Imports
 
 var GlobalObject = global.Object;
-var MathMax;
 var toStringTagSymbol = utils.ImportNow("to_string_tag_symbol");
 
-utils.Import(function(from) {
-  MathMax = from.MathMax;
-});
-
 // -------------------------------------------------------------------
 
 
 function CheckSharedIntegerTypedArray(ia) {
   if (!%IsSharedIntegerTypedArray(ia)) {
     throw MakeTypeError(kNotIntegerSharedTypedArray, ia);
   }
 }
 
 function CheckSharedInteger32TypedArray(ia) {
@@ skipping 107 matching lines @@
   if (index < 0 || index >= %_TypedArrayGetLength(ia)) {
     return UNDEFINED;
   }
   if (IS_UNDEFINED(timeout)) {
     timeout = INFINITY;
   } else {
     timeout = TO_NUMBER(timeout);
     if (NUMBER_IS_NAN(timeout)) {
       timeout = INFINITY;
     } else {
-      timeout = MathMax(0, timeout);
+      timeout = MAX_SIMPLE(0, timeout);
     }
   }
   return %AtomicsFutexWait(ia, index, value, timeout);
 }
 
 function AtomicsFutexWakeJS(ia, index, count) {
   CheckSharedInteger32TypedArray(ia);
   index = TO_INTEGER(index);
   if (index < 0 || index >= %_TypedArrayGetLength(ia)) {
     return UNDEFINED;
   }
-  count = MathMax(0, TO_INTEGER(count));
+  count = MAX_SIMPLE(0, TO_INTEGER(count));

[Michael Starzinger, 2015/10/07 19:02:23]

I don't have a machine where I could verify this right now, but I am pretty sure
this is observable now ...

Atomics.futexWait(a, 0, something_that_observes_ToNumber)

   return %AtomicsFutexWake(ia, index, count);
 }
 
 function AtomicsFutexWakeOrRequeueJS(ia, index1, count, value, index2) {
   CheckSharedInteger32TypedArray(ia);
   index1 = TO_INTEGER(index1);
-  count = MathMax(0, TO_INTEGER(count));
+  count = MAX_SIMPLE(0, TO_INTEGER(count));

[Michael Starzinger, 2015/10/07 19:02:23]

Likewise.

   value = TO_INT32(value);
   index2 = TO_INTEGER(index2);
   if (index1 < 0 || index1 >= %_TypedArrayGetLength(ia) ||
       index2 < 0 || index2 >= %_TypedArrayGetLength(ia)) {
     return UNDEFINED;
   }
   return %AtomicsFutexWakeOrRequeue(ia, index1, count, value, index2);
 }
 
 // -------------------------------------------------------------------
@@ skipping 25 matching lines @@
   "or", AtomicsOrJS,
   "xor", AtomicsXorJS,
   "exchange", AtomicsExchangeJS,
   "isLockFree", AtomicsIsLockFreeJS,
   "futexWait", AtomicsFutexWaitJS,
   "futexWake", AtomicsFutexWakeJS,
   "futexWakeOrRequeue", AtomicsFutexWakeOrRequeueJS,
 ]);
 
 })