Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1390013002: [heap] remove unneeded call to LowerInlineAllocationLimit (Closed)

Created:
5 years, 2 months ago by ofrobots
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] remove unneeded call to LowerInlineAllocationLimit Calling LowerInlineAllocationLimit from the bottom of Heap::Scavenge seems to be a no-op. new_space_.LowerInlineAllocationLimit( new_space_.inline_allocation_limit_step()); LowerInlineAllocatoinLimit does the following things: 1. Set the inline_allocation_limit_step_ to the passed in value. No-op. 2. Calls UpdateInlineAllocationLimit(0). This is unnecessary here as it has already been called when new_space_.ResetAllocationInfo was called above. 3. Sets top_on_previous_step_. This again is unnecessary as it gets reached by ResetAllocationInfo as well. BUG= R=hpayer@chromium.org,ulan@chromium.org Committed: https://crrev.com/9f8e8b835a468b1622c5350a01a97bc32c5b2fb7 Cr-Commit-Position: refs/heads/master@{#31156}

Patch Set 1 #

Patch Set 2 : delete NewSpace::inline_allocation_limit_step #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/spaces.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
ofrobots
5 years, 2 months ago (2015-10-06 22:27:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390013002/1
5 years, 2 months ago (2015-10-06 22:41:08 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 2 months ago (2015-10-06 22:41:10 UTC) #5
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-10-07 05:58:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390013002/20001
5 years, 2 months ago (2015-10-07 14:55:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-07 15:19:44 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9f8e8b835a468b1622c5350a01a97bc32c5b2fb7 Cr-Commit-Position: refs/heads/master@{#31156}
5 years, 2 months ago (2015-10-07 15:20:06 UTC) #10
ofrobots
5 years, 1 month ago (2015-10-25 10:18:27 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1405043005/ by ofrobots@google.com.

The reason for reverting is: Causes memory footprint regression:
https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without
counting the allocated memory towards a step. Calling LowerInlineAllocationLimit
this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL
(https://codereview.chromium.org/1404523002/) can address the 'bluntness' of
calling LowerInlineAllocationLimit from here along with leaving a comment about
the intent.

revert_cq: 1
revert_reason_textarea: Causes memory footprint regression:
https://code.google.com/p/chromium/issues/detail?id=541135

The intent of the code here was to advance the inline allocation limit without
counting the allocated memory towards a step. Calling LowerInlineAllocationLimit
this way is a blunt way of doing it, but it works.

At this point it is simplest to revert this CL. My follow-on CL
(https://codereview.chromium.org/1404523002/) can address the 'bluntness' of
calling LowerInlineAllocationLimit from here along with leaving a comment about
the intent..

Powered by Google App Engine
This is Rietveld 408576698