Issue 1389953002: [GN]: mac toolchain BUILD file housecleaning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1389953002: [GN]: mac toolchain BUILD file housecleaning (Closed)

Created:
5 years, 2 months ago by kal

Modified:
5 years, 2 months ago

Reviewers:
brettw, Bons

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[GN]: mac toolchain BUILD file housecleaning BUG=none R=andybons@chromium.org Committed: https://crrev.com/8fd6c67f04a47afdd66ad4a6ca5f23fa5a1f04a7 Cr-Commit-Position: refs/heads/master@{#352671}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	build/toolchain/mac/BUILD.gn	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389953002/1

5 years, 2 months ago (2015-10-06 19:15:35 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-10-06 19:57:28 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/8fd6c67f04a47afdd66ad4a6ca5f23fa5a1f04a7
Cr-Commit-Position: refs/heads/master@{#352671}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages