Move crashes_ui resources and utils to //components/crash

Move crashes_ui resources and utils to //components/crash

TBR=jochen

Committed: https://crrev.com/b7e240e71cb1d7aa559c65355e73dddc7665eca5
Cr-Commit-Position: refs/heads/master@{#353044}

[droger, 2015-10-06 14:20:17]

Patchset #1 (id:1) has been deleted

[droger, 2015-10-06 14:42:42]

Patchset #1 (id:20001) has been deleted

[droger, 2015-10-06 14:43:01]

droger@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2015-10-06 15:26:50]

It seems like the entire crashes_ui.cc could be moved to the component with a
little effort, rather than just the resources.

[blundell, 2015-10-06 15:28:37]

On 2015/10/06 15:26:50, Robert Sesek wrote:
> It seems like the entire crashes_ui.cc could be moved to the component with a
> little effort, rather than just the resources.

The intent of this work is to enable sharing as much as possible with iOS. iOS
can't share crashes_ui.* since it depends directly on //content's WebUI
infrastructure.

[droger, 2015-10-06 15:34:50]

On 2015/10/06 15:28:37, blundell wrote:
> On 2015/10/06 15:26:50, Robert Sesek wrote:
> > It seems like the entire crashes_ui.cc could be moved to the component with
a
> > little effort, rather than just the resources.
> 
> The intent of this work is to enable sharing as much as possible with iOS. iOS
> can't share crashes_ui.* since it depends directly on //content's WebUI
> infrastructure.

This design is the result of several discussions with content and iOS OWNERS.
The conclusion was that sharing the actual WebUI code is desirable but cannot be
done without introducing too much coupling between //content and //ios.
That's why we only share the resources.

[Robert Sesek, 2015-10-06 20:13:35]

Ah, right iOS WebUI is non-//content based.

https://codereview.chromium.org/1389913002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/crashes_ui.cc (right):

https://codereview.chromium.org/1389913002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/crashes_ui.cc:47:
source->AddLocalizedString(crash::kCrashesUIShortProductName,
Could you expose an array of struct{const char* name, int resource_id} to make
this a little less brittle?

[droger, 2015-10-07 09:39:10]

droger@chromium.org changed reviewers:
+ blundell@chromium.org

[droger, 2015-10-07 09:39:10]

+blundell as OWNER for //components resources

https://codereview.chromium.org/1389913002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/crashes_ui.cc (right):

https://codereview.chromium.org/1389913002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/crashes_ui.cc:47:
source->AddLocalizedString(crash::kCrashesUIShortProductName,
On 2015/10/06 20:13:35, Robert Sesek wrote:
> Could you expose an array of struct{const char* name, int resource_id} to make
> this a little less brittle?

Good suggestion.
Done, except for IDS_SHORT_PRODUCT_NAME, which I would argue does not belong to
the component. Let me know if you feel strongly about this, because we do have
Google-specific strings in components, so it would be technically possible to
move it there.

[blundell, 2015-10-07 09:40:29]

//components/resources LGTM

[Robert Sesek, 2015-10-07 16:40:16]

LGTM

[droger, 2015-10-08 11:38:39]

droger@chromium.org changed reviewers:
+ jochen@chromium.org

[droger, 2015-10-08 11:38:39]

TBR=jochen for OWNER of:
- chrome/app/theme (resource removed)
- chrome/browser/ui/BUILD.gn
- chrome/browser/ui/views/tabs/tab.cc (#include change)
- chrome/browser/ui/webui/crashes_ui.cc (use the new API)

[droger, 2015-10-08 11:39:05]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2015-10-08 11:39:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1389913002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1389913002/60001

[commit-bot: I haz the power, 2015-10-08 13:00:51]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-10-08 13:01:47]

Patchset 2 (id:??) landed as
https://crrev.com/b7e240e71cb1d7aa559c65355e73dddc7665eca5
Cr-Commit-Position: refs/heads/master@{#353044}