Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138983004: [OriginChip, OSX] Show & select URL on cmd-l. (Closed)

Created:
6 years, 10 months ago by groby-ooo-7-16
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Justin Donnelly, Greg Billock
Visibility:
Public.

Description

[OriginChip, OSX] Show & select URL on cmd-l. This is reflecting the Views change made in r240444 and is specific to the OriginChip being enabled. BUG=315944 R=shess@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251197

Patch Set 1 #

Patch Set 2 : Added a tweak around navigating back to NTP #

Patch Set 3 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 2 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
groby-ooo-7-16
PTAL
6 years, 10 months ago (2014-02-06 02:30:51 UTC) #1
Scott Hess - ex-Googler
lgtm
6 years, 10 months ago (2014-02-07 02:22:44 UTC) #2
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 10 months ago (2014-02-07 02:36:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/138983004/30001
6 years, 10 months ago (2014-02-07 02:37:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 05:10:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=259573
6 years, 10 months ago (2014-02-07 05:10:50 UTC) #6
Justin Donnelly
The CQ bit was checked by jdonnelly@chromium.org
6 years, 10 months ago (2014-02-07 05:34:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/138983004/30001
6 years, 10 months ago (2014-02-07 05:36:05 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 07:29:30 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) app_list_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 10 months ago (2014-02-07 07:29:31 UTC) #10
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 10 months ago (2014-02-11 23:35:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/138983004/430001
6 years, 10 months ago (2014-02-11 23:38:50 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 00:00:57 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=261859
6 years, 10 months ago (2014-02-12 00:00:58 UTC) #14
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 10 months ago (2014-02-13 22:06:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/138983004/430001
6 years, 10 months ago (2014-02-13 22:08:38 UTC) #16
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 00:12:12 UTC) #17
Message was sent while issue was closed. 
Change committed as 251197

Powered by Google App Engine
This is Rietveld 408576698