Chromium Code Reviews| Index: nss/lib/certdb/genname.c |
| =================================================================== |
| --- nss/lib/certdb/genname.c (revision 195639) |
| +++ nss/lib/certdb/genname.c (working copy) |
| @@ -686,7 +686,7 @@ |
| CERTNameConstraints * |
| cert_DecodeNameConstraints(PRArenaPool *reqArena, |
| - SECItem *encodedConstraints) |
| + const SECItem *encodedConstraints) |
| { |
| CERTNameConstraints *constraints; |
| SECStatus rv; |
| @@ -1064,7 +1064,8 @@ |
| ** names from a cert in preparation for a name constraints test. |
| */ |
| CERTGeneralName * |
| -CERT_GetConstrainedCertificateNames(CERTCertificate *cert, PRArenaPool *arena, |
| +CERT_GetConstrainedCertificateNames(const CERTCertificate *cert, |
| + PRArenaPool *arena, |
| PRBool includeSubjectCommonName) |
| { |
| CERTGeneralName *DN; |
| @@ -1340,13 +1341,13 @@ |
| ** or if some code fails (e.g. out of memory, or invalid constraint) |
| */ |
| SECStatus |
| -cert_CompareNameWithConstraints(CERTGeneralName *name, |
| - CERTNameConstraint *constraints, |
| +cert_CompareNameWithConstraints(const CERTGeneralName *name, |
| + const CERTNameConstraint *constraints, |
| PRBool excluded) |
| { |
| SECStatus rv = SECSuccess; |
| SECStatus matched = SECFailure; |
| - CERTNameConstraint *current; |
| + const CERTNameConstraint *current; |
| PORT_Assert(constraints); /* caller should not call with NULL */ |
| if (!constraints) { |
| @@ -1464,7 +1465,7 @@ |
| } |
| if (matched == SECSuccess || rv != SECSuccess) |
| break; |
| - current = CERT_GetNextNameConstraint(current); |
| + current = CERT_GetNextNameConstraint((CERTNameConstraint*)current); |
|
wtc
2013/04/24 22:49:45
I verified this "const cast" is fine.
|
| } while (current != constraints); |
| if (rv == SECSuccess) { |
| if (matched == SECSuccess) |
| @@ -1565,8 +1566,8 @@ |
| */ |
| SECStatus |
| CERT_CheckNameSpace(PRArenaPool *arena, |
| - CERTNameConstraints *constraints, |
| - CERTGeneralName *currentName) |
| + const CERTNameConstraints *constraints, |
| + const CERTGeneralName *currentName) |
| { |
| CERTNameConstraint *matchingConstraints; |
| SECStatus rv = SECSuccess; |