Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 13898011: Move SupportsUserData code into AutofillWebData (Closed)

Created:
7 years, 8 months ago by Cait (Slow)
Modified:
7 years, 7 months ago
Reviewers:
akalin, dhollowa
CC:
chromium-reviews, Raman Kakilate, akalin, estade+watch_chromium.org, benquan, Raghu Simha, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, dhollowa+watch_chromium.org, Albert Bodenhamer, haitaol1, Ilya Sherman, tim (not reviewing), Jói
Visibility:
Public.

Description

Move SupportsUserData code into AutofillWebData, so base class can live completely on UI thread. (depends on https://codereview.chromium.org/14103021/) TBR=akalin@chromium.org (c/b/sync) BUG=230920 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197149

Patch Set 1 : #

Patch Set 2 : Rebase and test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -43 lines) Patch
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/browser/webdata/autofill_webdata_service.h View 4 chunks +29 lines, -0 lines 0 comments Download
M components/autofill/browser/webdata/autofill_webdata_service.cc View 2 chunks +22 lines, -1 line 0 comments Download
M components/webdata/common/web_data_service_base.h View 3 chunks +0 lines, -25 lines 0 comments Download
M components/webdata/common/web_data_service_base.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cait (Slow)
David: PTAL at components/(autofill/browser/)webdata/ Joi: FYI
7 years, 8 months ago (2013-04-19 19:17:22 UTC) #1
dhollowa
lgtm
7 years, 8 months ago (2013-04-19 19:28:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/13898011/9001
7 years, 7 months ago (2013-04-29 19:00:57 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-04-29 21:32:36 UTC) #4
Message was sent while issue was closed.
Change committed as 197149

Powered by Google App Engine
This is Rietveld 408576698