Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 138973004: Fix failing AAC51 youtube certification test (Closed)

Created:
6 years, 11 months ago by qinmin
Modified:
6 years, 11 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix failing AAC51 youtube certification test Currently we assume audio output is either mono or stereo. This is wrong if the output channel is larger than 2. This CL fixes the issue by mapping the number of channels to their corresponding AudioFormat constants. BUG=312818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qinmin
PTAL
6 years, 11 months ago (2014-01-15 01:22:35 UTC) #1
xhwang
lgtm lgtm
6 years, 11 months ago (2014-01-15 01:29:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/138973004/1
6 years, 11 months ago (2014-01-15 05:55:52 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 17:18:07 UTC) #4
Message was sent while issue was closed.
Change committed as 245222

Powered by Google App Engine
This is Rietveld 408576698