Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Unified Diff: chrome/browser/component_updater/background_downloader_win.h

Issue 138973003: Race condition in component_updater::BackgroundDowloader (follow up) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/component_updater/background_downloader_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/background_downloader_win.h
diff --git a/chrome/browser/component_updater/background_downloader_win.h b/chrome/browser/component_updater/background_downloader_win.h
index 9d11a5d268f67ea271cd382a1a24311b86fad3ea..d1a08f8469b001b2d039a747e24662e98f5e9fb9 100644
--- a/chrome/browser/component_updater/background_downloader_win.h
+++ b/chrome/browser/component_updater/background_downloader_win.h
@@ -36,6 +36,9 @@ class BackgroundDownloader : public CrxDownloader {
// Called asynchronously on the FILE thread at different stages during
// the download. |OnDownloading| can be called multiple times.
+ // |EndDownload| switches the execution flow from the FILE to the UI thread.
+ // Accessing any data members of this object on the FILE thread after
+ // calling |EndDownload| is unsafe.
void BeginDownload(const GURL& url);
void OnDownloading();
void EndDownload(HRESULT hr);
« no previous file with comments | « no previous file | chrome/browser/component_updater/background_downloader_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698