Remove unnecessary friend decls; fix Win-Clang builds

Remove unnecessary friend decls; fix Win-Clang builds

Clang builds on Windows were failing with:

..\..\v8\src\register-configuration.cc(85,17) :  error: unqualified friend
declaration referring to type outside of the nearest enclosing namespace is
a Microsoft extension; add a nested name specifier
[-Werror,-Wmicrosoft-unqualified-friend]

  friend struct Register;
                ^
                ::v8::internal::

How did it work on non-Windows? The friend declarations were declaring
new Register and DoubleRegister structs in the current namespace, instead
of refering the existing classes in the outer namespce.

The code isn't referencing any private members of these classes anyway,
so let's drop the friend declarations.

BUG=82385
LOG=n

Committed: https://crrev.com/57ca0f36c4ad575105f3a35505fd430874d575c9
Cr-Commit-Position: refs/heads/master@{#31113}

[hans, 2015-10-05 18:04:46]

hans@chromium.org changed reviewers:
+ danno@chromium.org, machenbach@google.com

[hans, 2015-10-05 18:05:16]

Please take a look.

This is currently breaking all Win-Clang builds, so it would be great if someone
could help land and roll this as soon as possible.

[Michael Achenbach, 2015-10-05 19:08:14]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-05 19:08:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1389723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1389723002/1

[commit-bot: I haz the power, 2015-10-05 19:11:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-05 19:11:48]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6385)

[Michael Achenbach, 2015-10-05 19:23:45]

machenbach@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Michael Achenbach, 2015-10-05 19:23:46]

Rubber-stamp lgtm to unblock you.

[Michael Achenbach, 2015-10-05 19:24:19]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-10-05 19:24:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1389723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1389723002/1

[commit-bot: I haz the power, 2015-10-05 19:34:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-05 19:35:05]

Patchset 1 (id:??) landed as
https://crrev.com/57ca0f36c4ad575105f3a35505fd430874d575c9
Cr-Commit-Position: refs/heads/master@{#31113}

[hans, 2015-10-05 19:40:50]

On 2015/10/05 19:23:46, Michael Achenbach wrote:
> Rubber-stamp lgtm to unblock you.

Thanks!