Issue 1389633003: Fixed checked-mode error in security_context_argument_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1389633003: Fixed checked-mode error in security_context_argument_test. (Closed)

Created:
5 years, 2 months ago by Bill Hesse

Modified:
5 years, 2 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fixed checked-mode error in security_context_argument_test. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/f65a2f6499ceffc4d7ba0543fa559f318d600ed8

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	tests/standalone/io/security_context_argument_test.dart	View		2 chunks	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Søren Gjesse

lgtm https://codereview.chromium.org/1389633003/diff/1/tests/standalone/io/security_context_argument_test.dart File tests/standalone/io/security_context_argument_test.dart (right): https://codereview.chromium.org/1389633003/diff/1/tests/standalone/io/security_context_argument_test.dart#newcode12 tests/standalone/io/security_context_argument_test.dart:12: bool argumentTypeError(e) => e is ArgumentError || e ...

5 years, 2 months ago (2015-10-05 13:25:36 UTC) #3

Bill Hesse

5 years, 2 months ago (2015-10-05 13:34:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f65a2f6499ceffc4d7ba0543fa559f318d600ed8 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages