Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138963007: Disable SpeedIndexImplTest.testVideoCompleteness on cros. (Closed)

Created:
6 years, 11 months ago by achuithb
Modified:
6 years, 11 months ago
Reviewers:
szym, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable SpeedIndexImplTest.testVideoCompleteness on cros. BUG=334841 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/metrics/speedindex_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
achuithb
Disabling till I can figure out what's going on.
6 years, 11 months ago (2014-01-16 23:34:22 UTC) #1
szym
LGTM. I'm not an OWNER though. I suspect there's some old module on the pythonpath.
6 years, 11 months ago (2014-01-16 23:35:40 UTC) #2
achuithb
On 2014/01/16 23:35:40, szym wrote: > LGTM. I'm not an OWNER though. It's fine. I ...
6 years, 11 months ago (2014-01-16 23:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/138963007/1
6 years, 11 months ago (2014-01-16 23:40:19 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=45217
6 years, 11 months ago (2014-01-16 23:58:19 UTC) #5
achuithb
Oops, I'm not an owner of perf/. Tony, could I get an owner lgtm please?
6 years, 11 months ago (2014-01-17 00:16:27 UTC) #6
tonyg
lgtm
6 years, 11 months ago (2014-01-17 00:28:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/138963007/1
6 years, 11 months ago (2014-01-17 00:28:45 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247850
6 years, 11 months ago (2014-01-17 06:28:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/138963007/1
6 years, 11 months ago (2014-01-17 11:12:58 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 14:16:22 UTC) #11
Message was sent while issue was closed. 
Change committed as 245514

Powered by Google App Engine
This is Rietveld 408576698