Stick windows to sides of workspaces

ash/wm/property_util.h

Index: ash/wm/property_util.h
diff --git a/ash/wm/property_util.h b/ash/wm/property_util.h
index 97d7b24b4cac6f16b0e5e867f407ec34e29b82bf..108f68c6d81799a4b6078c537cb2bd69cc9dde59 100644
--- a/ash/wm/property_util.h
+++ b/ash/wm/property_util.h
@@ -6,6 +6,7 @@
 #define ASH_WM_PROPERTY_UTIL_H_
 
 #include "ash/ash_export.h"
+#include "base/basictypes.h"
 
 namespace aura {
 class RootWindow;
@@ -62,6 +63,19 @@ ASH_EXPORT void SetWindowAlwaysRestoresToRestoreBounds(aura::Window* window,
 ASH_EXPORT bool GetWindowAlwaysRestoresToRestoreBounds(
     const aura::Window* window);
 
+// Enum for possible edges that a window is docked on to the dock
+enum DockEdge {
+  DOCK_EDGE_NONE,
+  DOCK_EDGE_LEFT,
+  DOCK_EDGE_RIGHT,
+};

[flackr, 2013/06/03 22:03:43]

I'm not sure if we need to track which edge each window is docked too
individually. The dock should have an alignment and all windows would either be
docked or not docked. When the first window is added to the dock we can use its
bounds to determine the alignment for the dock.

[varkha, 2013/06/04 03:13:50]

I thought this allows to keep the logic of comparing bounds in only one place.
If we use one boolean property we would need to recalculate what we already did.
The performance hit is of course negligible but there would be some code
duplication that I was trying to avoid.

[flackr, 2013/06/04 19:58:10]

At the point when you determine the dock edge, you could call something on the
dock layout manager to set the side the dock is on and then you wouldn't have to
recalculate the side. But I understand the reasoning and leave it up to you.

+
+// Sets whether the specified window is docked near a screen edge.
+// Default is DOCK_EDGE_NONE and may change when a window is moved by user or
+// when the dock alignment is changed.

[flackr, 2013/06/03 22:03:43]

You mean when the shelf alignment is changed right?

[varkha, 2013/06/04 03:13:50]

Done.

+ASH_EXPORT void SetDockEdge(aura::Window* window, DockEdge value);
+ASH_EXPORT DockEdge GetDockEdge(const aura::Window* window);
+
 // Sets whether the specified window is tracked by workspace code. Default is
 // true. If set to false the workspace does not switch the current workspace,
 // nor does it attempt to impose constraints on the bounds of the window. This