Stick windows to sides of workspaces

ash/wm/drag_window_resizer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_DRAG_WINDOW_RESIZER_H_
 #define ASH_WM_DRAG_WINDOW_RESIZER_H_
 
 #include "ash/wm/window_resizer.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
@@ skipping 11 matching lines @@
   virtual ~DragWindowResizer();
 
   // Creates a new DragWindowResizer. The caller takes ownership of the
   // returned object. The ownership of |next_window_resizer| is taken by the
   // returned object. Returns NULL if not resizable.
   static DragWindowResizer* Create(WindowResizer* next_window_resizer,
                                    aura::Window* window,
                                    const gfx::Point& location,
                                    int window_component);
 
-  // WindowResizer overides:
+  // WindowResizer:
   virtual void Drag(const gfx::Point& location, int event_flags) OVERRIDE;
   virtual void CompleteDrag(int event_flags) OVERRIDE;
   virtual void RevertDrag() OVERRIDE;
   virtual aura::Window* GetTarget() OVERRIDE;
 
-  const gfx::Point& GetInitialLocationInParentForTest() const {
-    return details_.initial_location_in_parent;
-  }
+ protected:
+  // WindowResizer:
+  virtual const gfx::Point& GetInitialLocationForTest() const OVERRIDE;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(DragWindowResizerTest, DragWindowController);
 
   // Creates DragWindowResizer that adds the ability of dragging windows across
   // displays to |next_window_resizer|. This object takes the ownership of
   // |next_window_resizer|.
   explicit DragWindowResizer(WindowResizer* next_window_resizer,
                              const Details& details);
 
   // Updates the bounds of the phantom window for window dragging. Set true on
   // |in_original_root| if the pointer is still in |window()->GetRootWindow()|.
   void UpdateDragWindow(const gfx::Rect& bounds, bool in_original_root);
 
   // Returns true if we should allow the mouse pointer to warp.
   bool ShouldAllowMouseWarp();
 
+  // Returns last created instance or NULL.
+  static DragWindowResizer* instance() { return last_instance; }
+
   scoped_ptr<WindowResizer> next_window_resizer_;
 
   // Shows a semi-transparent image of the window being dragged.
   scoped_ptr<DragWindowController> drag_window_controller_;
 
   const Details details_;
 
   gfx::Point last_mouse_location_;
 
   // If non-NULL the destructor sets this to true. Used to determine if this has
   // been deleted.
   bool* destroyed_;
 
+  // Last instance created - for use by the DragWindowResizerTest.
+  static DragWindowResizer* last_instance;

[sky, 2013/06/17 19:49:47]

Why the last here? Isn't this the current instance? This should also end up with
a '_' (it's a member). So, I suggest instance_. Also, I recommend nuking
instance() entirely and using instance_ directly.

[flackr, 2013/06/17 20:02:40]

Ah, my mistake, I had just recommended this to avoid confusing this for a
singleton class. Agree with nuking the accessor.

[varkha, 2013/06/17 20:34:57]

Done.

[varkha, 2013/06/17 20:34:57]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(DragWindowResizer);
 };
 
 }  // namespace internal
 }  // namespace aura
 
 #endif  // ASH_WM_DRAG_WINDOW_RESIZER_H_