ash/wm/window_properties.h - Issue 13896026: Stick windows to sides of workspaces

Side by Side Diff: ash/wm/window_properties.h

Issue 13896026: Stick windows to sides of workspaces (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Preserve docked state when launcher auto-hide changes. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ASH_WM_WINDOW_PROPERTIES_H_	5 #ifndef ASH_WM_WINDOW_PROPERTIES_H_

6 #define ASH_WM_WINDOW_PROPERTIES_H_	6 #define ASH_WM_WINDOW_PROPERTIES_H_

7	7

8 #include "ash/ash_export.h"	8 #include "ash/ash_export.h"

9 #include "ash/wm/property_util.h"	9 #include "ash/wm/property_util.h"

10 #include "ui/aura/window.h"	10 #include "ui/aura/window.h"

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
91	91

92 // A property key to remember if a windows position can be managed by the	92 // A property key to remember if a windows position can be managed by the

93 // workspace manager or not.	93 // workspace manager or not.

94 ASH_EXPORT extern const aura::WindowProperty<bool>* const	94 ASH_EXPORT extern const aura::WindowProperty<bool>* const

95 kWindowPositionManagedKey;	95 kWindowPositionManagedKey;

96	96

97 // A property key to tell the workspace layout manager to always restore the	97 // A property key to tell the workspace layout manager to always restore the

98 // window to the restore-bounds (false by default).	98 // window to the restore-bounds (false by default).

99 extern const aura::WindowProperty<bool>* const kWindowRestoresToRestoreBounds;	99 extern const aura::WindowProperty<bool>* const kWindowRestoresToRestoreBounds;

100	100

	101 // A bitmask containing the workspace edges that the window is stuck to.
	flackr 2013/05/01 17:34:04 I don't think we'll have any useful behaviors for I don't think we'll have any useful behaviors for windows being "stuck" to more than one edge. We should probably only remember the right or left and perhaps neither if the window is touching both. varkha 2013/05/18 03:06:37 I am not sure. When the gutter appears, say on the I am not sure. When the gutter appears, say on the right with the non-maximized window moving the gutter boundary left would eventually squeeze the window to the left of it to be stuck to both edges. In this state dragging the gutter boundary back to the right I think should preserve the window touching both the left edge (screen) and the right edge (gutter edge). This can now be done by resizing the screen. Also resizing to both right and left or docking to max-left or max-right creates multiple edges situations that we probably want to maintain when gutter and / or launcher size and / or visibility change. flackr 2013/05/22 02:00:56 For now, I think a window touching a gutter should Show quoted text On 2013/05/18 03:06:37, varkha wrote: > I am not sure. When the gutter appears, say on the right with the non-maximized > window moving the gutter boundary left would eventually squeeze the window to > the left of it to be stuck to both edges. In this state dragging the gutter > boundary back to the right I think should preserve the window touching both the > left edge (screen) and the right edge (gutter edge). This can now be done by > resizing the screen. > Also resizing to both right and left or docking to max-left or max-right creates > multiple edges situations that we probably want to maintain when gutter and / or > launcher size and / or visibility change. For now, I think a window touching a gutter should not be considered "stuck". We only want to allow one gutter at a time.
	102 extern const aura::WindowProperty<int>* const kWindowStuckToEdge;

	103

101 // True if the window is controlled by the workspace manager.	104 // True if the window is controlled by the workspace manager.

102 extern const aura::WindowProperty<bool>* const	105 extern const aura::WindowProperty<bool>* const kWindowTrackedByWorkspaceKey;

103 kWindowTrackedByWorkspaceKey;

104	106

105 // Alphabetical sort.	107 // Alphabetical sort.

106	108

107 } // namespace internal	109 } // namespace internal

108 } // namespace ash	110 } // namespace ash

109	111

110 #endif // ASH_WM_WINDOW_PROPERTIES_H_	112 #endif // ASH_WM_WINDOW_PROPERTIES_H_

OLD	NEW

« ash/ash_switches.cc ('K') | « ash/wm/property_util.cc ('k') | ash/wm/window_properties.cc » ('j') | ash/wm/workspace/workspace_layout_manager.cc » ('J')