Stick windows to sides of workspaces

ash/wm/stacking_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/stacking_controller.h"
 
 #include "ash/display/display_controller.h"
 #include "ash/session_state_delegate.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/always_on_top_controller.h"
 #include "ash/wm/coordinate_conversion.h"
+#include "ash/wm/property_util.h"
 #include "ash/wm/window_properties.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/window.h"
 #include "ui/base/ui_base_types.h"
 
 namespace ash {
 namespace {
 
 // Find a root window that matches the |bounds|. If the virtual screen
@@ skipping 55 matching lines @@
     target_root = FindContainerRoot(bounds);
   }
 
   switch (window->type()) {
     case aura::client::WINDOW_TYPE_NORMAL:
     case aura::client::WINDOW_TYPE_POPUP:
       if (IsSystemModal(window))
         return GetSystemModalContainer(target_root, window);
       else if (HasTransientParentWindow(window))
         return GetContainerForWindow(window->transient_parent());
+      else if (IsWindowDocked(window))
+        return GetContainerById(target_root,
+                                internal::kShellWindowId_DockContainer);

[flackr, 2013/06/11 17:59:31]

nit: multi-line block requires curlies {}

[varkha, 2013/06/12 04:52:13]

Eliminating the window property made this piece unnecessary I think.

       return GetAlwaysOnTopController(target_root)->GetContainer(window);
     case aura::client::WINDOW_TYPE_CONTROL:
       return GetContainerById(
           target_root, internal::kShellWindowId_UnparentedControlContainer);
     case aura::client::WINDOW_TYPE_PANEL:
       if (IsPanelAttached(window))
         return GetContainerById(target_root,
                                 internal::kShellWindowId_PanelContainer);
+      else if (IsWindowDocked(window))
+        return GetContainerById(target_root,
+                                internal::kShellWindowId_DockContainer);
       else
         return GetAlwaysOnTopController(target_root)->GetContainer(window);
     case aura::client::WINDOW_TYPE_MENU:
       return GetContainerById(
           target_root, internal::kShellWindowId_MenuContainer);
     case aura::client::WINDOW_TYPE_TOOLTIP:
       return GetContainerById(
           target_root, internal::kShellWindowId_DragImageAndTooltipContainer);
     default:
       NOTREACHED() << "Window " << window->id()
@@ skipping 49 matching lines @@
     controller->SetAlwaysOnTopContainer(
         root_window->GetChildById(
             internal::kShellWindowId_AlwaysOnTopContainer));
     // RootWindow owns the AlwaysOnTopController object.
     root_window->SetProperty(internal::kAlwaysOnTopControllerKey, controller);
   }
   return controller;
 }
 
 }  // namespace ash