Stick windows to sides of workspaces

ash/wm/workspace/workspace_window_resizer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_WORKSPACE_WINDOW_RESIZER_H_
 #define ASH_WM_WORKSPACE_WINDOW_RESIZER_H_
 
 #include <vector>
 
+#include "ash/wm/property_util.h"
 #include "ash/wm/window_resizer.h"
 #include "ash/wm/workspace/magnetism_matcher.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "ui/aura/window_tracker.h"
 
 namespace ash {
 namespace internal {
 
@@ skipping 74 matching lines @@
   // returns the number of pixels that couldn't be allocated to the attached
   // windows (due to min/max size constraints).
   // Note the return value can be positive or negative, a negative value
   // indicating that that many pixels couldn't be removed from the attached
   // windows.
   int CalculateAttachedSizes(
       int delta,
       int available_size,
       std::vector<int>* sizes) const;
 
+  // Returns an edge touching the dock bounds when dock is not opened yet or
+  // the edge representing the side that the dock is opened on.
+  DockEdge FindDockEdge(const gfx::Rect& bounds) const;
+
   // Divides |amount| evenly between |sizes|. If |amount| is negative it
   // indicates how many pixels |sizes| should be shrunk by.
   // Returns how many pixels failed to be allocated/removed from |sizes|.
   int GrowFairly(int amount, std::vector<WindowSize>& sizes) const;
 
   // Calculate the ratio of pixels that each WindowSize in |sizes| should
   // receive when growing or shrinking.
   void CalculateGrowthRatios(const std::vector<WindowSize*>& sizes,
                              std::vector<float>* out_ratios) const;
 
@@ skipping 69 matching lines @@
   // Gives a previews of where the the window will end up. Only used if there
   // is a grid and the caption is being dragged.
   scoped_ptr<PhantomWindowController> snap_phantom_window_controller_;
 
   // Used to determine the target position of a snap.
   scoped_ptr<SnapSizer> snap_sizer_;
 
   // Last SnapType.
   SnapType snap_type_;
 
+  // Last updated touched edge.

[stevenjb, 2013/06/03 18:19:03]

Can you expand this comment? It's not entirely clear to me why this needs to be
here, instead of in DockWindowResizer.

[varkha, 2013/06/03 21:03:17]

This is how I track a window that is still part of workspace but has been
dragged to the side and so it is not yet part of dock and does not have
DockWindowResizer attached to it. Is this OK or do you think we should always
chain in DockWindowResizer for all windows and handle all potential drags there?
I have expanded the comment as well.

+  ash::DockEdge dock_edge_;
+
   // Number of mouse moves since the last bounds change. Only used for phantom
   // placement to track when the mouse is moved while pushed against the edge of
   // the screen.
   int num_mouse_moves_since_bounds_change_;
 
   // The mouse location passed to Drag().
   gfx::Point last_mouse_location_;
 
   // Window the drag has magnetically attached to.
   aura::Window* magnetism_window_;
 
   // Used to verify |magnetism_window_| is still valid.
   aura::WindowTracker window_tracker_;
 
   // If |magnetism_window_| is non-NULL this indicates how the two windows
   // should attach.
   MatchedEdge magnetism_edge_;
 
   DISALLOW_COPY_AND_ASSIGN(WorkspaceWindowResizer);
 };
 
 }  // namespace internal
 }  // namespace ash
 
 #endif  // ASH_WM_WORKSPACE_WINDOW_RESIZER_H_