Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: Source/core/platform/text/RegularExpression.h

Issue 13896017: Switch RegularExpression from YARR to V8 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/platform/text/RegularExpression.h
diff --git a/Source/core/platform/text/RegularExpression.h b/Source/core/platform/text/RegularExpression.h
index 6224e742bdcfefa0128202884a47575bb3e0d426..8b99f4d2102d0d9369daf9544ed25969542fe08b 100644
--- a/Source/core/platform/text/RegularExpression.h
+++ b/Source/core/platform/text/RegularExpression.h
@@ -26,11 +26,10 @@
#ifndef RegularExpression_h
#define RegularExpression_h
-#include <wtf/BumpPointerAllocator.h>
+#include "ScopedPersistent.h"
#include <wtf/Noncopyable.h>
-#include <wtf/PassOwnPtr.h>
#include <wtf/text/WTFString.h>
-#include <yarr/Yarr.h>
+#include <v8.h>
namespace WebCore {
@@ -47,11 +46,7 @@ public:
int match(const String&, int startFrom = 0, int* matchLength = 0) const;
private:
- PassOwnPtr<JSC::Yarr::BytecodePattern> compile(const String&, TextCaseSensitivity, MultilineMode);
-
- unsigned m_numSubpatterns;
- OwnPtr<JSC::Yarr::BytecodePattern> m_regExpByteCode;
- BumpPointerAllocator m_regexAllocator;
+ ScopedPersistent<v8::RegExp> m_regex;
};
void replace(String&, const RegularExpression&, const String&);
« no previous file with comments | « no previous file | Source/core/platform/text/RegularExpression.cpp » ('j') | Source/core/platform/text/RegularExpression.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698