Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 13896014: Enable removing spelling markers in a frame (Closed)

Created:
7 years, 8 months ago by please use gerrit instead
Modified:
7 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, abarth_chromum.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable removing spelling markers in a frame This patch enables removing all spelling markers in a frame. Chrome will call this method for all frames when the user turns off spellcheck. BUG=125508 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148694

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M Source/WebKit/chromium/public/WebFrame.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebFrameImpl.h View 1 chunk +1 line, -0 lines 1 comment Download
M Source/WebKit/chromium/src/WebFrameImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/WebFrameTest.cpp View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
please use gerrit instead
Kent: PTAL. ("git cl upload" recommended you as a reviewer.)
7 years, 8 months ago (2013-04-18 19:23:27 UTC) #1
tkent
lgtm https://codereview.chromium.org/13896014/diff/1/Source/WebKit/chromium/src/WebFrameImpl.h File Source/WebKit/chromium/src/WebFrameImpl.h (right): https://codereview.chromium.org/13896014/diff/1/Source/WebKit/chromium/src/WebFrameImpl.h#newcode182 Source/WebKit/chromium/src/WebFrameImpl.h:182: virtual void removeSpellingMarkers(); nit: We should append OVERRIDE. ...
7 years, 8 months ago (2013-04-18 21:39:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/13896014/5001
7 years, 8 months ago (2013-04-18 21:52:35 UTC) #3
commit-bot: I haz the power
"webkit_tests" failed. Giving up immediately. Builder is linux_layout_rel, revision is HEAD
7 years, 8 months ago (2013-04-18 22:12:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/13896014/5001
7 years, 8 months ago (2013-04-18 22:32:48 UTC) #5
commit-bot: I haz the power
"webkit_tests" failed. Giving up immediately. Builder is linux_layout_rel, revision is HEAD
7 years, 8 months ago (2013-04-18 22:32:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/13896014/1
7 years, 8 months ago (2013-04-18 22:35:21 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 23:22:26 UTC) #8
Message was sent while issue was closed.
Change committed as 148694

Powered by Google App Engine
This is Rietveld 408576698