Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc

Issue 13896011: Make javascript dialogs into top-level windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/corewm/focus_controller.cc » ('j') | ui/views/corewm/focus_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc
diff --git a/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc b/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc
index 016ffe5e0d072b0a256e317d0faa31696c7f2a53..2cfeaed32bfaeca3f862bc0b3d83ebc63ae9dc9a 100644
--- a/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc
+++ b/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc
@@ -84,12 +84,9 @@ JavaScriptAppModalDialog::~JavaScriptAppModalDialog() {
NativeAppModalDialog* JavaScriptAppModalDialog::CreateNativeDialog() {
gfx::NativeWindow parent_window =
web_contents()->GetView()->GetTopLevelNativeWindow();
-#if defined(USE_AURA)
- if (!parent_window->GetRootWindow()) {
- // When we are part of a WebContents that isn't actually being displayed on
- // the screen, we can't actually attach to it.
- parent_window = NULL;
- }
+#if defined(USE_AURA) && defined(OS_WIN)
+ // Javascript dialogs should be top-level windows in desktop WinAura.
+ parent_window = NULL;
#endif
return NativeAppModalDialog::CreateNativeJavaScriptPrompt(this,
parent_window);
« no previous file with comments | « no previous file | ui/views/corewm/focus_controller.cc » ('j') | ui/views/corewm/focus_controller.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698