Make javascript dialogs into top-level windows.

ui/views/corewm/focus_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/corewm/focus_controller.h"
 
 #include "base/auto_reset.h"
 #include "ui/aura/client/activation_change_observer.h"
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/client/capture_client.h"
@@ skipping 235 matching lines @@
     WindowLostFocusFromDispositionChange(params.receiver, params.old_parent);
   }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // FocusController, private:
 
 void FocusController::SetFocusedWindow(aura::Window* window) {
   if (updating_focus_ || window == focused_window_)
     return;
-  DCHECK(rules_->CanFocusWindow(window));
+
+  // When a modal dialog appears, SetFocusedWindow gets called by
+  // ClearNativeFocus for the previously active window as it is deactivated. In
+  // this case, CanFocusWindow returns false and this method has no further
+  // work to do.
+  if (!rules_->CanFocusWindow(window))

[Ben Goodger (Google), 2013/04/25 17:19:28]

I'm not happy with this. I've made it thus far that this function used a dcheck
and not an early return because I expected the callers to do validation. Can you
find some other way of doing this?

[robertshield, 2013/04/26 18:40:42]

I reverted this bit and instead now perform a check in DNWA::ClearNativeFocus to
see whether the window can be focused.

+    return;
+
   if (window)
     DCHECK_EQ(window, rules_->GetFocusableWindow(window));
 
   base::AutoReset<bool> updating_focus(&updating_focus_, true);
   aura::Window* lost_focus = focused_window_;
   if (focused_window_ && observer_manager_.IsObserving(focused_window_) &&
       focused_window_ != active_window_) {
     observer_manager_.Remove(focused_window_);
   }
   focused_window_ = window;
@@ skipping 71 matching lines @@
 void FocusController::WindowFocusedFromInputEvent(aura::Window* window) {
   // Only focus |window| if it or any of its parents can be focused. Otherwise
   // FocusWindow() will focus the topmost window, which may not be the
   // currently focused one.
   if (rules_->CanFocusWindow(GetToplevelWindow(window)))
     FocusWindow(window);
 }
 
 }  // namespace corewm
 }  // namespace views