Sort methods of drive::ChangeListLoader.

Sort methods of drive::ChangeListLoader.

Made header and source ordering consistent.
And more importantly, grouped relevant methods as much as possible, and
sorted in the order of execution, so that the source code is easily read
from top to bottom.

BUG=none.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194794

[kinaba, 2013-04-18 05:25:33]

Please take a look.

The modification is big but it is just sorting methods.
In the .h header it was mostly sane already, but I felt very
irritating when I read .cc source.

[satorux1, 2013-04-18 05:31:43]

LGTM with nits

https://codereview.chromium.org/13896005/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/change_list_loader.h (right):

https://codereview.chromium.org/13896005/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/change_list_loader.h:70: void
CheckForUpdates(const FileOperationCallback& callback);
Is this a good place? Maybe move this above LoadIfNeeded()

I thought LoadIfNeeded() and  LoadDirectoryFromServer() would be placed
consecutively

https://codereview.chromium.org/13896005/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/change_list_loader.h:100: // |callback| must not
be null.
Could you add: TODO(satorux): Make this private. crbug.com/232208

[kinaba, 2013-04-18 05:42:38]

https://codereview.chromium.org/13896005/diff/2001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/change_list_loader.h (right):

https://codereview.chromium.org/13896005/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/change_list_loader.h:70: void
CheckForUpdates(const FileOperationCallback& callback);
On 2013/04/18 05:31:43, satorux1 wrote:
> Is this a good place? Maybe move this above LoadIfNeeded()
> 
> I thought LoadIfNeeded() and  LoadDirectoryFromServer() would be placed
> consecutively 

Done.

https://codereview.chromium.org/13896005/diff/2001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/change_list_loader.h:100: // |callback| must not
be null.
On 2013/04/18 05:31:43, satorux1 wrote:
> Could you add: TODO(satorux): Make this private. crbug.com/232208

Done.

[kinaba, 2013-04-18 05:55:43]

Committed patchset #3 manually as r194794 (presubmit successful).