content/browser/bluetooth/bluetooth_dispatcher_host.cc - Issue 1389553002: bluetooth: Detect and fix incorrect thread usage of BluetoothDispatcherHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/bluetooth/bluetooth_dispatcher_host.cc

Issue 1389553002: bluetooth: Detect and fix incorrect thread usage of BluetoothDispatcherHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/bluetooth/bluetooth_dispatcher_host.h ('k') | device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java » ('j') | device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/bluetooth/bluetooth_dispatcher_host.cc

diff --git a/content/browser/bluetooth/bluetooth_dispatcher_host.cc b/content/browser/bluetooth/bluetooth_dispatcher_host.cc

index decbede43c15dfcb8ab6af0e74e5d6360fa158d9..0d6cdea41cf0de1d9def37d7def28f264882b1c4 100644

--- a/content/browser/bluetooth/bluetooth_dispatcher_host.cc

+++ b/content/browser/bluetooth/bluetooth_dispatcher_host.cc

@@ -171,6 +171,11 @@ BluetoothDispatcherHost::BluetoothDispatcherHost(int render_process_id)

/*is_repeating=*/false),

weak_ptr_factory_(this) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

+ // Bind all future weak pointers to the UI thread.

+ weak_ptr_on_ui_thread_ = weak_ptr_factory_.GetWeakPtr();

+ weak_ptr_on_ui_thread_.get();

if (BluetoothAdapterFactory::IsBluetoothAdapterAvailable())

BluetoothAdapterFactory::GetAdapter(

base::Bind(&BluetoothDispatcherHost::set_adapter,