Issue 138953016: [style] Remove braces from single-line if statements for style consistency.

Issue 138953016: [style] Remove braces from single-line if statements for style consistency. (Closed)

Created:
6 years, 11 months ago by eroman

Modified:
6 years, 10 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[style] Remove braces from single-line if statements for style consistency. BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248133

Patch Set 2 : Rebase #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -69 lines)			Patch
M	content/renderer/webcrypto/webcrypto_impl.cc	View	1	6 chunks	+12 lines, -18 lines	0 comments	Download
M	content/renderer/webcrypto/webcrypto_impl_nss.cc	View	1	12 chunks	+18 lines, -33 lines	0 comments	Download
M	content/renderer/webcrypto/webcrypto_impl_openssl.cc	View	1	5 chunks	+9 lines, -14 lines	0 comments	Download
M	content/renderer/webcrypto/webcrypto_impl_unittest.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

Otherwise LGTM https://codereview.chromium.org/138953016/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc File content/renderer/webcrypto/webcrypto_impl_nss.cc (right): https://codereview.chromium.org/138953016/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc#newcode306 content/renderer/webcrypto/webcrypto_impl_nss.cc:306: if (tag_length_bits > 128 || (tag_length_bits % ...

6 years, 10 months ago (2014-01-30 04:24:38 UTC) #2

eroman

https://codereview.chromium.org/138953016/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc File content/renderer/webcrypto/webcrypto_impl_nss.cc (right): https://codereview.chromium.org/138953016/diff/1/content/renderer/webcrypto/webcrypto_impl_nss.cc#newcode306 content/renderer/webcrypto/webcrypto_impl_nss.cc:306: if (tag_length_bits > 128 || (tag_length_bits % 8 != ...

6 years, 10 months ago (2014-01-31 02:27:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/138953016/70001

6 years, 10 months ago (2014-01-31 02:29:37 UTC) #4

commit-bot: I haz the power

6 years, 10 months ago (2014-01-31 05:33:02 UTC) #6

Message was sent while issue was closed.

CQ bit was unchecked on CL. Ignoring.

Expand Messages | Collapse Messages