Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1389513002: Fix XP builds after r352208. (Closed)

Created:
5 years, 2 months ago by jam
Modified:
5 years, 2 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, asanka, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, benjhayden+dwatch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix XP builds after r352208. I had a temporary use of a Vista+ function that I forgot to switch to the wrapper. Also GetFileInformationByHandleEx has to be wrapped. TBR=yzshen@chromium.org BUG=478251 Committed: https://crrev.com/f2a730174378e9cb79abf9cdc14976aefe807127 Cr-Commit-Position: refs/heads/master@{#352238}

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -15 lines) Patch
M mojo/edk/system/raw_channel_win.cc View 1 5 chunks +41 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jam
5 years, 2 months ago (2015-10-03 03:57:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389513002/1
5 years, 2 months ago (2015-10-03 03:57:55 UTC) #3
yzshen1
lgtm
5 years, 2 months ago (2015-10-03 04:27:19 UTC) #5
jam
On 2015/10/03 04:27:19, yzshen1 wrote: > lgtm added another method btw
5 years, 2 months ago (2015-10-03 04:28:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389513002/20001
5 years, 2 months ago (2015-10-03 04:29:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-03 05:08:19 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-03 05:08:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f2a730174378e9cb79abf9cdc14976aefe807127
Cr-Commit-Position: refs/heads/master@{#352238}

Powered by Google App Engine
This is Rietveld 408576698