Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1389483003: Remove no-op code from text_page.html (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 2 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove no-op code from text_page.html Remove JS code which calls into undefined functions from text_page.html The undefined code was slowing down the page load and making ChromeTabUtils#waitForTabPageLoaded() in TabsTest#testCloseTabDuringFling timeout BUG=None TEST=None Committed: https://crrev.com/9a9fb4a1d4084e6b6d8e92484a1e41ecc9e46f62 Cr-Commit-Position: refs/heads/master@{#352239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M chrome/test/data/android/tabstest/text_page.html View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pkotwicz
Newton, can you please take a look? The external JS scripts were removed in https://chrome-internal-review.googlesource.com/#/c/40008/2 ...
5 years, 2 months ago (2015-10-03 00:03:07 UTC) #2
newt (away)
lgtm thanks!
5 years, 2 months ago (2015-10-03 00:12:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389483003/1
5 years, 2 months ago (2015-10-03 00:15:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-03 05:09:00 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-03 05:09:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a9fb4a1d4084e6b6d8e92484a1e41ecc9e46f62
Cr-Commit-Position: refs/heads/master@{#352239}

Powered by Google App Engine
This is Rietveld 408576698