Issue 1389473002: only send final completion notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1389473002: only send final completion notification (Closed)

Created:
5 years, 2 months ago by danrubel

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, devoncarew

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

only send final completion notification This shaves 1 ms off the average completion notification response time R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/d14a9635467c0b998a3086c29c7dd93b642d0326

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -14 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/integration/integration_tests.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/completion/completion_computer_test.dart	View	1	3 chunks	+12 lines, -13 lines	0 comments	Download

Total messages: 4 (1 generated)

danrubel

5 years, 2 months ago (2015-10-06 18:21:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d14a9635467c0b998a3086c29c7dd93b642d0326 (presubmit successful).