Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chrome/browser/ui/cocoa/autofill/simple_grid_layout_unittest.mm

Issue 138943002: [rAC, OSX] Adjust red outline for NSPopUpButtons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Special-casing around NSIntegralRect's 0-width special case. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/autofill/simple_grid_layout.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/autofill/simple_grid_layout_unittest.mm
diff --git a/chrome/browser/ui/cocoa/autofill/simple_grid_layout_unittest.mm b/chrome/browser/ui/cocoa/autofill/simple_grid_layout_unittest.mm
index da517c7e054393ae87dd4b612da17f289a50aa70..2927852aaacf56cba837f72499c24e134b5d0a6f 100644
--- a/chrome/browser/ui/cocoa/autofill/simple_grid_layout_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/simple_grid_layout_unittest.mm
@@ -20,13 +20,15 @@ class ColumnLayout : public SimpleGridLayout {
class LayoutTest : public testing::Test {
public:
base::scoped_nsobject<NSView> CreateViewWithWidth(float width) {
- NSRect frame = NSMakeRect(0, 0, width, 0);
+ // Height of 1, since empty rects become 0x0 when run by NSIntegralRect.
+ NSRect frame = NSMakeRect(0, 0, width, 1);
base::scoped_nsobject<NSView> view([[NSView alloc] initWithFrame:frame]);
return view;
}
+ // Width of 1, since empty rects become 0x0 when run by NSIntegralRect.
base::scoped_nsobject<NSView> CreateViewWithHeight(float height) {
- NSRect frame = NSMakeRect(0, 0, 0, height);
+ NSRect frame = NSMakeRect(0, 0, 1, height);
base::scoped_nsobject<NSView> view([[NSView alloc] initWithFrame:frame]);
return view;
}
« no previous file with comments | « chrome/browser/ui/cocoa/autofill/simple_grid_layout.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698