Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3627)

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm

Issue 138943002: [rAC, OSX] Adjust red outline for NSPopUpButtons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Special-casing around NSIntegralRect's 0-width special case. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/autofill/autofill_section_container.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm b/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm
index bdfcd80d754fef12497b464b617ac4ef6f908b17..6f2b17c97254e0f5903f8ffc6053ad1ea6e285f5 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm
@@ -88,12 +88,10 @@
[super drawBezelWithFrame:frame inView:controlView];
if (invalid_) {
// Mimic the rounded rect of default popup bezel in size, outline in red.
- NSBezierPath* path = [NSBezierPath
- bezierPathWithRoundedRect:
- NSOffsetRect(
- NSInsetRect(NSIntegralRect(frame), 3.5, 3.5), -1.0, -1.0)
- xRadius:4.0
- yRadius:4.0];
+ NSRect outlineRect = NSOffsetRect(NSInsetRect(frame, 3.0, 3.5), -.5, -1.0);
+ NSBezierPath* path = [NSBezierPath bezierPathWithRoundedRect:outlineRect
+ xRadius:3.5
+ yRadius:3.5];
[path setLineWidth:0];
[[NSColor redColor] setStroke];
[path stroke];
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/autofill/autofill_section_container.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698