third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp - Issue 1389383003: WIP: Introduce CompressibleString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp

Issue 1389383003: WIP: Introduce CompressibleString Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: haraken's review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.h ('k') | third_party/WebKit/Source/core/dom/ScriptLoader.cpp » ('j') | third_party/WebKit/Source/core/dom/ScriptLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp

index b83ceb66726eb4bb2b63041a52edc2cd005f839f..69ccd42e5a739e8572d8adbea8cf30c024e514a2 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp

@@ -180,7 +180,7 @@ v8::Isolate* WorkerScriptController::isolate() const

return m_workerGlobalScope->thread()->isolate();

}

-ScriptValue WorkerScriptController::evaluate(const String& script, const String& fileName, const TextPosition& scriptStartPosition, CachedMetadataHandler* cacheHandler, V8CacheOptions v8CacheOptions)

+ScriptValue WorkerScriptController::evaluate(const CompressibleString& script, const String& fileName, const TextPosition& scriptStartPosition, CachedMetadataHandler* cacheHandler, V8CacheOptions v8CacheOptions)

{

if (!initializeContextIfNeeded())

return ScriptValue();