tools/perf/page_sets/blink_memory_mobile.py - Issue 1389383003: WIP: Introduce CompressibleString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/blink_memory_mobile.py

Issue 1389383003: WIP: Introduce CompressibleString Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Bug fix Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/blink_memory_mobile.py

diff --git a/tools/perf/page_sets/blink_memory_mobile.py b/tools/perf/page_sets/blink_memory_mobile.py

index 3c18085caf5003ccb88281b339eec0a0e13c2aee..30c78cfb64317cd8005de91b4b2b43a53531d74f 100644

--- a/tools/perf/page_sets/blink_memory_mobile.py

+++ b/tools/perf/page_sets/blink_memory_mobile.py

@@ -26,6 +26,8 @@ class BlinkMemoryMobilePage(page_module.Page):

with action_runner.CreateInteraction(phase):

action_runner.Wait(DUMP_WAIT_TIME)

action_runner.ForceGarbageCollection()

+ # Swtich this manually!

+ action_runner.ExecuteJavaScript('window.purgeMemory()')

action_runner.Wait(DUMP_WAIT_TIME)

if not action_runner.tab.browser.DumpMemory():

logging.error('Unable to get a memory dump for %s.', self.name)