WIP: Introduce CompressibleString

third_party/WebKit/Source/core/fetch/ScriptResource.h

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
     Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
     Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
     version 2 of the License, or (at your option) any later version.
@@ skipping 11 matching lines @@
     This class provides all functionality needed for loading images, style sheets and html
     pages from the web. It has a memory cache for these objects.
 */
 
 #ifndef ScriptResource_h
 #define ScriptResource_h
 
 #include "core/CoreExport.h"
 #include "core/fetch/ResourceClient.h"
 #include "core/fetch/TextResource.h"
+#include "wtf/text/CompressableString.h"
 
 namespace blink {
 
 class FetchRequest;
 class ScriptResource;
 
 class CORE_EXPORT ScriptResourceClient : public ResourceClient {
 public:
     ~ScriptResourceClient() override {}
     static ResourceClientType expectedType() { return ScriptType; }
     ResourceClientType resourceClientType() const final { return expectedType(); }
 
     virtual void notifyAppendData(ScriptResource* resource) { }
 };
 
 class CORE_EXPORT ScriptResource final : public TextResource {
 public:
     typedef ScriptResourceClient ClientType;
     static ResourcePtr<ScriptResource> fetch(FetchRequest&, ResourceFetcher*);
 
     // Public for testing
     ScriptResource(const ResourceRequest&, const String& charset);
 
     ~ScriptResource() override;
 
     void didAddClient(ResourceClient*) override;
     void appendData(const char*, unsigned) override;
 
-    const String& script();
+    RefPtrWillBeRawPtr<CompressableString> script();

[esprehn, 2015/10/24 03:59:25]

not a ref ptr

 
     AtomicString mimeType() const;
 
     bool mimeTypeAllowedByNosniff() const;
 
     void setIntegrityMetadata(const String& metadata) { m_integrityMetadata = metadata; }
     String integrityMetadata() const { return m_integrityMetadata; }
     void setIntegrityAlreadyChecked(bool checked) { m_integrityChecked = checked; }
     bool integrityAlreadyChecked() { return m_integrityChecked; }
     bool mustRefetchDueToIntegrityMetadata(const FetchRequest&) const override;
 
 private:
     class ScriptResourceFactory : public ResourceFactory {
     public:
         ScriptResourceFactory()
             : ResourceFactory(Resource::Script) { }
 
         Resource* create(const ResourceRequest& request, const String& charset) const override
         {
             return new ScriptResource(request, charset);
         }
     };
 
     bool m_integrityChecked;
     String m_integrityMetadata;
 
-    AtomicString m_script;
+    RefPtrWillBeMember<CompressableString> m_script;

[esprehn, 2015/10/24 03:59:25]

By making these not atomic strings you lose the de-duping behavior which is bad,
you need to add an atomization layer around your compressed string system,
otherwise this doesn't generalize to style where we need hash tables of
CompressableStrings.

 };
 
 DEFINE_RESOURCE_TYPE_CASTS(Script);
 
 }
 
 #endif