runtime/vm/native_api_impl.cc - Issue 1389353004: Remove isolate argument from handle allocation: Part II

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_api_impl.cc

Issue 1389353004: Remove isolate argument from handle allocation: Part II (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: c Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/native_api_impl.cc

diff --git a/runtime/vm/native_api_impl.cc b/runtime/vm/native_api_impl.cc

index da1d09964a6d5aec8e11df27502693529b30433d..5f091ba5fd36ac1bc7354dfcd11958ac77677d7d 100644

--- a/runtime/vm/native_api_impl.cc

+++ b/runtime/vm/native_api_impl.cc

@@ -71,7 +71,8 @@ DART_EXPORT bool Dart_CloseNativePort(Dart_Port native_port_id) {

static void CompileAll(Isolate* isolate, Dart_Handle* result) {

ASSERT(isolate != NULL);

- const Error& error = Error::Handle(isolate, Library::CompileAll());

+ const Error& error =

+ Error::Handle(isolate->current_zone(), Library::CompileAll());

if (error.IsNull()) {

*result = Api::Success();

} else {

« no previous file with comments | « runtime/vm/message.cc ('k') | runtime/vm/native_entry.cc » ('j') | no next file with comments »