Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: runtime/vm/native_api_impl.cc

Issue 1389353004: Remove isolate argument from handle allocation: Part II (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: c Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/message.cc ('k') | runtime/vm/native_entry.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "include/dart_native_api.h" 5 #include "include/dart_native_api.h"
6 6
7 #include "platform/assert.h" 7 #include "platform/assert.h"
8 #include "vm/dart_api_impl.h" 8 #include "vm/dart_api_impl.h"
9 #include "vm/dart_api_message.h" 9 #include "vm/dart_api_message.h"
10 #include "vm/dart_api_state.h" 10 #include "vm/dart_api_state.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 64
65 // TODO(turnidge): Check that the port is native before trying to close. 65 // TODO(turnidge): Check that the port is native before trying to close.
66 return PortMap::ClosePort(native_port_id); 66 return PortMap::ClosePort(native_port_id);
67 } 67 }
68 68
69 69
70 // --- Verification tools --- 70 // --- Verification tools ---
71 71
72 static void CompileAll(Isolate* isolate, Dart_Handle* result) { 72 static void CompileAll(Isolate* isolate, Dart_Handle* result) {
73 ASSERT(isolate != NULL); 73 ASSERT(isolate != NULL);
74 const Error& error = Error::Handle(isolate, Library::CompileAll()); 74 const Error& error =
75 Error::Handle(isolate->current_zone(), Library::CompileAll());
75 if (error.IsNull()) { 76 if (error.IsNull()) {
76 *result = Api::Success(); 77 *result = Api::Success();
77 } else { 78 } else {
78 *result = Api::NewHandle(isolate, error.raw()); 79 *result = Api::NewHandle(isolate, error.raw());
79 } 80 }
80 } 81 }
81 82
82 83
83 DART_EXPORT Dart_Handle Dart_CompileAll() { 84 DART_EXPORT Dart_Handle Dart_CompileAll() {
84 DARTSCOPE(Thread::Current()); 85 DARTSCOPE(Thread::Current());
85 Dart_Handle result = Api::CheckAndFinalizePendingClasses(I); 86 Dart_Handle result = Api::CheckAndFinalizePendingClasses(I);
86 if (::Dart_IsError(result)) { 87 if (::Dart_IsError(result)) {
87 return result; 88 return result;
88 } 89 }
89 CHECK_CALLBACK_STATE(I); 90 CHECK_CALLBACK_STATE(I);
90 CompileAll(I, &result); 91 CompileAll(I, &result);
91 return result; 92 return result;
92 } 93 }
93 94
94 } // namespace dart 95 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/message.cc ('k') | runtime/vm/native_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698