Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 1389353002: [interpreter] Make --ignition-filter script filtering explicit. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Make --ignition-filter script filtering explicit. This makes it explicit when the --ignition-filter pattern should be applied to the script name instead of the function name by using a proper "s:{name}" pattern. It also hardcodes it to be a prefix match instead of an exact match, because that is all we need for test262. R=rmcilroy@chromium.org Committed: https://crrev.com/6c97e54f279058d828a5c5fde9a55e9279f53506 Cr-Commit-Position: refs/heads/master@{#31153}

Patch Set 1 #

Patch Set 2 : Fix bounds check. #

Patch Set 3 : Small reordering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -48 lines) Patch
M src/compiler.cc View 1 3 chunks +17 lines, -6 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/objects.cc View 1 2 2 chunks +24 lines, -36 lines 0 comments Download
M test/test262/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-07 13:39:40 UTC) #1
Michael Starzinger
+Benedikt
5 years, 2 months ago (2015-10-07 13:39:57 UTC) #3
rmcilroy
Works for me, thanks for cleaning it up! lgtm.
5 years, 2 months ago (2015-10-07 13:46:14 UTC) #4
Benedikt Meurer
LGTM from my side
5 years, 2 months ago (2015-10-07 14:18:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389353002/40001
5 years, 2 months ago (2015-10-07 14:19:21 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-07 14:27:29 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 14:28:00 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6c97e54f279058d828a5c5fde9a55e9279f53506
Cr-Commit-Position: refs/heads/master@{#31153}

Powered by Google App Engine
This is Rietveld 408576698