Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1389333005: Remove parserAdd from DocumentOrderedList. (Closed)

Created:
5 years, 2 months ago by tasak
Modified:
5 years, 2 months ago
Reviewers:
kochi, kouhei (in TOK)
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove parserAdd from DocumentOrderedList. Since HTMLParser reparents elements (including HTMLStyleElement), we cannot expect that all elements are given in the document order. So we need to find where the given element is inserted into DocumentOrderedList. BUG=353564 TEST=third_party/WebKit/LayoutTests/fast/dom/HTMLStyleElement/parser-reparent.html Committed: https://crrev.com/2cd49bb3ebb9ce32d49aa2dd7a80ca0593855890 Cr-Commit-Position: refs/heads/master@{#353247}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/HTMLStyleElement/parser-reparent.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/HTMLStyleElement/parser-reparent-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentOrderedList.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentOrderedList.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
tasak
Would you review this CL?
5 years, 2 months ago (2015-10-08 02:23:06 UTC) #2
kouhei (in TOK)
On 2015/10/08 02:23:06, tasak wrote: > Would you review this CL? Please measure perf impact ...
5 years, 2 months ago (2015-10-08 02:26:54 UTC) #3
tasak
On 2015/10/08 02:26:54, kouhei (catching-up) wrote: > On 2015/10/08 02:23:06, tasak wrote: > > Would ...
5 years, 2 months ago (2015-10-08 02:33:39 UTC) #4
kochi
tasak, could enlighten me how/why the red style in the original layout test file can ...
5 years, 2 months ago (2015-10-08 03:28:07 UTC) #5
tasak
On 2015/10/08 03:28:07, Takayoshi Kochi wrote: > tasak, could enlighten me how/why the red style ...
5 years, 2 months ago (2015-10-08 04:40:34 UTC) #6
kochi
On 2015/10/08 04:40:34, tasak wrote: > On 2015/10/08 03:28:07, Takayoshi Kochi wrote: > > tasak, ...
5 years, 2 months ago (2015-10-08 06:18:15 UTC) #7
kouhei (in TOK)
On 2015/10/08 06:18:15, Takayoshi Kochi wrote: > On 2015/10/08 04:40:34, tasak wrote: > > On ...
5 years, 2 months ago (2015-10-08 06:19:49 UTC) #8
tasak
On 2015/10/08 06:19:49, kouhei (catching-up) wrote: > On 2015/10/08 06:18:15, Takayoshi Kochi wrote: > > ...
5 years, 2 months ago (2015-10-09 05:22:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389333005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389333005/20001
5 years, 2 months ago (2015-10-09 05:23:03 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-09 07:59:31 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 08:00:21 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2cd49bb3ebb9ce32d49aa2dd7a80ca0593855890
Cr-Commit-Position: refs/heads/master@{#353247}

Powered by Google App Engine
This is Rietveld 408576698