Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: third_party/WebKit/Source/core/css/invalidation/InvalidationSetTest.cpp

Issue 1389333003: Do not keep InvalidationSets on the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/invalidation/InvalidationSetTest.cpp
diff --git a/third_party/WebKit/Source/core/css/invalidation/InvalidationSetTest.cpp b/third_party/WebKit/Source/core/css/invalidation/InvalidationSetTest.cpp
index 80254e6ed503c8da64ee667f554409342f9856e8..471d9f324443e0d695f91727a739e7e241f7e484 100644
--- a/third_party/WebKit/Source/core/css/invalidation/InvalidationSetTest.cpp
+++ b/third_party/WebKit/Source/core/css/invalidation/InvalidationSetTest.cpp
@@ -12,7 +12,7 @@ namespace blink {
// Once we setWholeSubtreeInvalid, we should not keep the HashSets.
TEST(InvalidationSetTest, SubtreeInvalid_AddBefore)
{
- RefPtrWillBeRawPtr<InvalidationSet> set = InvalidationSet::create();
+ RefPtr<InvalidationSet> set = InvalidationSet::create();
set->addClass("a");
set->setWholeSubtreeInvalid();
@@ -22,7 +22,7 @@ TEST(InvalidationSetTest, SubtreeInvalid_AddBefore)
// Don't (re)create HashSets if we've already setWholeSubtreeInvalid.
TEST(InvalidationSetTest, SubtreeInvalid_AddAfter)
{
- RefPtrWillBeRawPtr<InvalidationSet> set = InvalidationSet::create();
+ RefPtr<InvalidationSet> set = InvalidationSet::create();
set->setWholeSubtreeInvalid();
set->addTagName("a");
@@ -32,8 +32,8 @@ TEST(InvalidationSetTest, SubtreeInvalid_AddAfter)
// No need to keep the HashSets when combining with a wholeSubtreeInvalid set.
TEST(InvalidationSetTest, SubtreeInvalid_Combine_1)
{
- RefPtrWillBeRawPtr<InvalidationSet> set1 = InvalidationSet::create();
- RefPtrWillBeRawPtr<InvalidationSet> set2 = InvalidationSet::create();
+ RefPtr<InvalidationSet> set1 = InvalidationSet::create();
+ RefPtr<InvalidationSet> set2 = InvalidationSet::create();
set1->addId("a");
set2->setWholeSubtreeInvalid();
@@ -47,8 +47,8 @@ TEST(InvalidationSetTest, SubtreeInvalid_Combine_1)
// No need to add HashSets from combining set when we already have wholeSubtreeInvalid.
TEST(InvalidationSetTest, SubtreeInvalid_Combine_2)
{
- RefPtrWillBeRawPtr<InvalidationSet> set1 = InvalidationSet::create();
- RefPtrWillBeRawPtr<InvalidationSet> set2 = InvalidationSet::create();
+ RefPtr<InvalidationSet> set1 = InvalidationSet::create();
+ RefPtr<InvalidationSet> set2 = InvalidationSet::create();
set1->setWholeSubtreeInvalid();
set2->addAttribute("a");
@@ -61,7 +61,7 @@ TEST(InvalidationSetTest, SubtreeInvalid_Combine_2)
TEST(InvalidationSetTest, SubtreeInvalid_AddCustomPseudoBefore)
{
- RefPtrWillBeRawPtr<InvalidationSet> set = InvalidationSet::create();
+ RefPtr<InvalidationSet> set = InvalidationSet::create();
set->setCustomPseudoInvalid();
ASSERT_FALSE(set->isEmpty());
@@ -72,7 +72,7 @@ TEST(InvalidationSetTest, SubtreeInvalid_AddCustomPseudoBefore)
#ifndef NDEBUG
TEST(InvalidationSetTest, ShowDebug)
{
- RefPtrWillBeRawPtr<InvalidationSet> set = InvalidationSet::create();
+ RefPtr<InvalidationSet> set = InvalidationSet::create();
set->show();
}
#endif // NDEBUG

Powered by Google App Engine
This is Rietveld 408576698