Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: chrome/browser/download/notification/download_notification_browsertest.cc

Issue 1389273004: Update first download notification correctly if there are multiple notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update the download manually in the test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/notification/download_notification_browsertest.cc
diff --git a/chrome/browser/download/notification/download_notification_browsertest.cc b/chrome/browser/download/notification/download_notification_browsertest.cc
index 4b72ddafcd3267bea4e296b8e9fd4a2e6d265bc3..6d08b3f26f9c220ce82c50cb8a3b482787034884 100644
--- a/chrome/browser/download/notification/download_notification_browsertest.cc
+++ b/chrome/browser/download/notification/download_notification_browsertest.cc
@@ -374,6 +374,11 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, DownloadFile) {
EXPECT_EQ(message_center::NOTIFICATION_TYPE_PROGRESS,
GetNotification(notification_id())->type());
+ // Confirms that the download update is delivered to the notification.
+ NotificationUpdateObserver download_notification_periodically_update_observer;
+ download_item()->UpdateObservers();
+ download_notification_periodically_update_observer.Wait();
+
NotificationUpdateObserver download_notification_update_observer;
// Requests to complete the download.
@@ -784,6 +789,17 @@ IN_PROC_BROWSER_TEST_F(DownloadNotificationTest, MAYBE_DownloadMultipleFiles) {
EXPECT_EQ(message_center::DEFAULT_PRIORITY,
GetNotification(notification_id2)->priority());
+ // Confirms that the updates of both download are delivered to the
+ // notifications.
+ NotificationUpdateObserver notification_periodically_update_observer1;
+ download1->UpdateObservers();
+ EXPECT_EQ(notification_id1,
+ notification_periodically_update_observer1.Wait());
+ NotificationUpdateObserver notification_periodically_update_observer2;
+ download2->UpdateObservers();
+ EXPECT_EQ(notification_id2,
+ notification_periodically_update_observer2.Wait());
+
// Requests to complete the downloads.
ui_test_utils::NavigateToURL(
browser(), GURL(net::URLRequestSlowDownloadJob::kFinishDownloadUrl));

Powered by Google App Engine
This is Rietveld 408576698