'View source code' option should be disabled in context menu for 'Paper Toolbar' of 'Pdf Viewer"

chrome/browser/renderer_context_menu/render_view_context_menu.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
@@ skipping 1135 matching lines @@
       if (!core_tab_helper)
         return false;
 
       CoreTabHelperDelegate* core_delegate = core_tab_helper->delegate();
       return !core_delegate ||
              core_delegate->CanReloadContents(embedder_web_contents_);
     }
 
     case IDC_VIEW_SOURCE:
     case IDC_CONTENT_CONTEXT_VIEWFRAMESOURCE:
-      return (params_.media_type != WebContextMenuData::MediaTypePlugin) &&
+      // If we're viewing in a MimeHandlerViewGuest source will not be viewed.
+      return !extensions::MimeHandlerViewGuest::FromWebContents(

[lazyboy, 2015/10/08 18:35:39]

Wouldn't this start showing view source for plugin elements? I'd keep the !=
MediaTypePlugin check.

[Deepak, 2015/10/09 05:29:05]

"view source" for the plugin elements will be disabled.

"params_.media_type != WebContextMenuData::MediaTypePlugin" will not help as 
when user right click on the "Zoom in" , "Zoom out" buttons of the material UI
then as these elements are not embedded in the content so "media_type" value
does not get updated to WebContextMenuData::MediaTypePlugin from
ContextMenuClientImpl::showContextMenu(), so this condition will pass and 
"view source" will remain enabled.

we need to put
!extensions::MimeHandlerViewGuest::FromWebContents(source_web_contents_) check 
then params_.media_type!=WebContextMenuData::MediaTypePlugin not required, as
params_.media_type
value get updated for plugins only.

Please correct me if I misunderstood something.

[lazyboy, 2015/10/09 15:46:38]

For regular plugins (not PDF, say flash), we'd get
MimeHandlerViewGuest::FromWebContents() == NULL and this will start
showing "view source". This would break existing behavior.
What I suggested is to do both of
if ((media_type != MediaTypePlugin || !MimeHandlerViewGuest:From) &&
  embedder_web_contents_->GetController().CanViewSource()) ...
Does that make sense?

Can you also write a test for this? Thanks.

+                 source_web_contents_) &&
              embedder_web_contents_->GetController().CanViewSource();
 
     case IDC_CONTENT_CONTEXT_INSPECTELEMENT:
     case IDC_CONTENT_CONTEXT_INSPECTBACKGROUNDPAGE:
     case IDC_CONTENT_CONTEXT_RELOAD_PACKAGED_APP:
     case IDC_CONTENT_CONTEXT_RESTART_PACKAGED_APP:
       return IsDevCommandEnabled(id);
 
     case IDC_CONTENT_CONTEXT_VIEWPAGEINFO:
       if (embedder_web_contents_->GetController().GetVisibleEntry() == NULL)
@@ skipping 810 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }