Use d8 instead of the experimental v8_shell.

Use d8 instead of the experimental v8_shell.

BUG=331585
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246726

[Nico, 2014-01-15 05:20:28]

lgtm once the blocker is resolved.

Thanks, sorry about this not actually working yet :-/

[jochen (gone - plz use gerrit), 2014-01-15 13:55:34]

On 2014/01/15 05:20:28, Nico wrote:
> lgtm once the blocker is resolved.
> 
> Thanks, sorry about this not actually working yet :-/

I fixed the v8 side... should be in the next roll.

[Sheridan Rawlins, 2014-01-15 17:29:53]

Including v8 roll to pick up https://code.google.com/p/v8/source/detail?r=18621

I'm not sure if try uses DEPS or .DEPS.git, but [git cl] trying it out.

[Nico, 2014-01-15 17:31:26]

On 2014/01/15 17:29:53, Sheridan Rawlins wrote:
> Including v8 roll to pick up
https://code.google.com/p/v8/source/detail?r=18621

Hm, I'd probably roll v8 in its own cl and land the rest of this cl a day later
if the v8 roll sticks…but up to you.

[Sheridan Rawlins, 2014-01-15 18:29:53]

Makes sense - looks like rolling just DEPS didn't take in the try.

Moved to CL 139543003

[jochen (gone - plz use gerrit), 2014-01-20 10:45:53]

ok, v8 rolled, so we should be good to go

lgtm

[commit-bot: I haz the power, 2014-01-21 15:23:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scr@chromium.org/138923005/300001

[Sheridan Rawlins, 2014-01-21 18:58:50]

http://build.chromium.org/p/tryserver.chromium/builders/win/builds/141872/ste...

Shows that invoking d8 on windows is failing for some reason, but it doesn't
seem incredibly obvious why.  I'll try to get a local windows build going and
see what I can uncover, unless one of you have any insights that you can share.

  File "../tools/gypv8sh.py", line 55, in <module>

    sys.exit(main())

  File "../tools/gypv8sh.py", line 44, in main

    subprocess.check_call(cmd, stdin=subprocess.PIPE, stdout=f)

  File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 540, in
check_call

    raise CalledProcessError(retcode, cmd)

subprocess.CalledProcessError: Command '['..\\out\\Debug/d8.exe', '-e',
'arguments=["../chrome/test/base/js2gtest.js",
"browser\\\\resources\\\\print_preview\\\\data\\\\measurement_system_unittest.gtestjs",
"chrome/browser\\\\resources\\\\print_preview\\\\data/measurement_system_unittest.gtestjs",
"..\\\\out\\\\Debug\\\\obj\\\\chrome\\\\unit_tests.gen/chrome/browser\\\\resources\\\\print_preview\\\\data/measurement_system_unittest-gen.cc",
"unit"]', '../chrome/third_party/mock4js/mock4js.js',
'../third_party/accessibility-audit/axs_testing.js',
'../chrome/test/data/webui/test_api.js', '../chrome/test/base/js2gtest.js']'
returned non-zero exit status 1

FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper
environment.x86
browser_tests_target_js2webui_17d0ad1d9b3e572c7951dae3bf287eb2.45cb8d065fc0180af2de189d63ea65fe.rsp
..\..\chrome

[jochen (gone - plz use gerrit), 2014-01-21 19:34:18]

ugh... I will look into this tomorrow if you didn't find the cause until
then.

I could imagine that it fails to load the ICU data files.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-22 02:55:34]

Retried try job too often on win for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[jochen (gone - plz use gerrit), 2014-01-22 14:00:47]

On 2014/01/22 02:55:34, I haz the power (commit-bot) wrote:
> Retried try job too often on win for step(s) compile
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

should be fixed by https://codereview.chromium.org/143983012 - i'll ping again
when this rolled into chromium

[Sheridan Rawlins, 2014-01-22 19:15:50]

Thanks!  jdonnelly@ and I tried to reproduce on his Win machine, and it built
just fine.

-SCR

[jochen (gone - plz use gerrit), 2014-01-23 19:42:20]

ok, should work now

[commit-bot: I haz the power, 2014-01-23 19:44:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scr@chromium.org/138923005/300001

[commit-bot: I haz the power, 2014-01-23 23:33:39]

Change committed as 246726