Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 138923005: Use d8 instead of the experimental v8_shell. (Closed)

Created:
6 years, 11 months ago by Sheridan Rawlins
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use d8 instead of the experimental v8_shell. BUG=331585 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246726

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rolling v8 to build d8#host. #

Patch Set 4 : Don't roll v8 in this CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/chrome_tests.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/js_unittest_rules.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Sheridan Rawlins
6 years, 11 months ago (2014-01-14 23:43:13 UTC) #1
Nico
lgtm once the blocker is resolved. Thanks, sorry about this not actually working yet :-/
6 years, 11 months ago (2014-01-15 05:20:28 UTC) #2
jochen (gone - plz use gerrit)
On 2014/01/15 05:20:28, Nico wrote: > lgtm once the blocker is resolved. > > Thanks, ...
6 years, 11 months ago (2014-01-15 13:55:34 UTC) #3
Sheridan Rawlins
Including v8 roll to pick up https://code.google.com/p/v8/source/detail?r=18621 I'm not sure if try uses DEPS or ...
6 years, 11 months ago (2014-01-15 17:29:53 UTC) #4
Nico
On 2014/01/15 17:29:53, Sheridan Rawlins wrote: > Including v8 roll to pick up https://code.google.com/p/v8/source/detail?r=18621 Hm, ...
6 years, 11 months ago (2014-01-15 17:31:26 UTC) #5
Sheridan Rawlins
Makes sense - looks like rolling just DEPS didn't take in the try. Moved to ...
6 years, 11 months ago (2014-01-15 18:29:53 UTC) #6
jochen (gone - plz use gerrit)
ok, v8 rolled, so we should be good to go lgtm
6 years, 11 months ago (2014-01-20 10:45:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/138923005/300001
6 years, 11 months ago (2014-01-21 15:23:19 UTC) #8
Sheridan Rawlins
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/141872/steps/compile/logs/stdio Shows that invoking d8 on windows is failing for some reason, but it doesn't ...
6 years, 11 months ago (2014-01-21 18:58:50 UTC) #9
jochen (gone - plz use gerrit)
ugh... I will look into this tomorrow if you didn't find the cause until then. ...
6 years, 11 months ago (2014-01-21 19:34:18 UTC) #10
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=142113
6 years, 11 months ago (2014-01-22 02:55:34 UTC) #11
jochen (gone - plz use gerrit)
On 2014/01/22 02:55:34, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 11 months ago (2014-01-22 14:00:47 UTC) #12
Sheridan Rawlins
Thanks! jdonnelly@ and I tried to reproduce on his Win machine, and it built just ...
6 years, 11 months ago (2014-01-22 19:15:50 UTC) #13
jochen (gone - plz use gerrit)
ok, should work now
6 years, 11 months ago (2014-01-23 19:42:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/138923005/300001
6 years, 11 months ago (2014-01-23 19:44:17 UTC) #15
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 23:33:39 UTC) #16
Message was sent while issue was closed.
Change committed as 246726

Powered by Google App Engine
This is Rietveld 408576698