Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: tools/perf/measurements/thread_times.py

Issue 138923004: Telemetry: Normalize fast-path results with frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Customize silk/fastpath results. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/thread_times.py
diff --git a/tools/perf/measurements/thread_times.py b/tools/perf/measurements/thread_times.py
index 4cb660aed71d49df916ecb45b4d97afae6d491b1..2f72fbf3c06ff74cdbef320c86fdfd1edd33fcba 100644
--- a/tools/perf/measurements/thread_times.py
+++ b/tools/perf/measurements/thread_times.py
@@ -11,8 +11,10 @@ class ThreadTimes(page_measurement.PageMeasurement):
self._metric = timeline.ThreadTimesTimelineMetric()
def AddCommandLineOptions(self, parser):
- parser.add_option('--report-renderer-main-details', action='store_true',
- help='Report details on the render main thread.')
+ parser.add_option('--report-silk-results', action='store_true',
+ help='Report results relevant to silk.')
+ parser.add_option('--report-silk-details', action='store_true',
+ help='Report details relevant to silk.')
def CanRunForPage(self, page):
return hasattr(page, 'smoothness')
@@ -23,8 +25,10 @@ class ThreadTimes(page_measurement.PageMeasurement):
def WillRunActions(self, page, tab):
self._metric.Start(page, tab)
- self._metric.report_renderer_main_details = \
- self.options.report_renderer_main_details
+ if self.options.report_silk_results:
+ self._metric.results_to_report = timeline.SilkResults
+ if self.options.report_silk_details:
+ self._metric.details_to_report = timeline.SilkDetails
def DidRunActions(self, page, tab):
self._metric.Stop(page, tab)

Powered by Google App Engine
This is Rietveld 408576698