Add support for showing CSS with distilled articles.

Add support for showing CSS with distilled articles.

Adds the Readability CSS and also makes the DOM Distiller viewer load it.

BUG=319881
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247675

[nyquist, 2014-01-14 22:14:59]

thakis: PTAL
tsepez: PTAL security review

[Tom Sepez, 2014-01-14 22:22:50]

LGTM for security.

https://codereview.chromium.org/138923002/diff/1/components/dom_distiller/con...
File components/dom_distiller/content/dom_distiller_viewer_source.cc (right):

https://codereview.chromium.org/138923002/diff/1/components/dom_distiller/con...
components/dom_distiller/content/dom_distiller_viewer_source.cc:27: const
std::string kCssPath = "readability.css";
This creates a Non-POD static initializer. Use const char[] instead, promote to
string later as needed.

https://codereview.chromium.org/138923002/diff/1/components/dom_distiller/con...
components/dom_distiller/content/dom_distiller_viewer_source.cc:111:
.GetRawDataResource(IDR_DISTILLER_CSS)
nit: not sure if the style guide wants the "."s on the end of the preceding
line.

[Nico, 2014-01-15 05:35:26]

lgtm

https://codereview.chromium.org/138923002/diff/1/components/dom_distiller/con...
File components/dom_distiller/content/dom_distiller_viewer_source.cc (right):

https://codereview.chromium.org/138923002/diff/1/components/dom_distiller/con...
components/dom_distiller/content/dom_distiller_viewer_source.cc:27: const
std::string kCssPath = "readability.css";
On 2014/01/14 22:22:50, Tom Sepez wrote:
> This creates a Non-POD static initializer. Use const char[] instead, promote
to
> string later as needed.

Yup.

https://codereview.chromium.org/138923002/diff/1/components/dom_distiller/con...
components/dom_distiller/content/dom_distiller_viewer_source.cc:111:
.GetRawDataResource(IDR_DISTILLER_CSS)
On 2014/01/14 22:22:50, Tom Sepez wrote:
> nit: not sure if the style guide wants the "."s on the end of the preceding
> line.

I think this is what clang-format produces.

[nyquist, 2014-01-15 22:50:58]

Addressed all comments. Still waiting for review of the two CLs this depends on,
so holding off commit.

https://codereview.chromium.org/138923002/diff/1/components/dom_distiller/con...
File components/dom_distiller/content/dom_distiller_viewer_source.cc (right):

https://codereview.chromium.org/138923002/diff/1/components/dom_distiller/con...
components/dom_distiller/content/dom_distiller_viewer_source.cc:27: const
std::string kCssPath = "readability.css";
On 2014/01/15 05:35:26, Nico wrote:
> On 2014/01/14 22:22:50, Tom Sepez wrote:
> > This creates a Non-POD static initializer. Use const char[] instead, promote
> to
> > string later as needed.
> 
> Yup.

Done.

https://codereview.chromium.org/138923002/diff/1/components/dom_distiller/con...
components/dom_distiller/content/dom_distiller_viewer_source.cc:111:
.GetRawDataResource(IDR_DISTILLER_CSS)
On 2014/01/15 05:35:26, Nico wrote:
> On 2014/01/14 22:22:50, Tom Sepez wrote:
> > nit: not sure if the style guide wants the "."s on the end of the preceding
> > line.
> 
> I think this is what clang-format produces.

Yeah, this is pure clang-format. Keeping as is then.

[nyquist, 2014-01-28 21:58:38]

cjhopman: //components/dom_distiller

[cjhopman, 2014-01-28 22:01:00]

lgtm

https://codereview.chromium.org/138923002/diff/190001/chrome/browser/dom_dist...
File chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc
(right):

https://codereview.chromium.org/138923002/diff/190001/chrome/browser/dom_dist...
chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc:233: //
The MIME-type should always be text/html.
comment doesn't match code

[nyquist, 2014-01-28 22:09:05]

https://codereview.chromium.org/138923002/diff/190001/chrome/browser/dom_dist...
File chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc
(right):

https://codereview.chromium.org/138923002/diff/190001/chrome/browser/dom_dist...
chrome/browser/dom_distiller/dom_distiller_viewer_source_browsertest.cc:233: //
The MIME-type should always be text/html.
On 2014/01/28 22:01:00, cjhopman wrote:
> comment doesn't match code

Done.

[commit-bot: I haz the power, 2014-01-29 07:38:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nyquist@chromium.org/138923002/210001

[commit-bot: I haz the power, 2014-01-29 11:25:30]

Change committed as 247675