[Cronet] Use Https for Quic Test Server

components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java

Index: components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java
diff --git a/components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java b/components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java
new file mode 100644
index 0000000000000000000000000000000000000000..44e82865f9b21fcdf1435192b979410ada457738
--- /dev/null
+++ b/components/cronet/android/test/src/org/chromium/net/MockCertVerifier.java
@@ -0,0 +1,28 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.net;
+
+import org.chromium.base.annotations.JNINamespace;
+
+/**
+ * A Java wrapper to supply a net::MockCertVerifier which can be then passed
+ * into {@link CronetEngine.Builder#setMockCertVerifierForTesting}.
+ * The native pointer will be freed when the CronetEngine is torn down.
+ */
+@JNINamespace("cronet")
+public class MockCertVerifier {
+    private MockCertVerifier() {}

[mef, 2015/10/20 20:43:34]

Maybe constructor should call nativeCreateMockCertVerifier() and store the
pointer in member variable and getNativePointer() should be just a getter, not
creator?

[xunjieli, 2015/10/20 20:57:26]

I had that initially, but Paul suggested using a static function to create a
native pointer. Both approaches are fine with me. But using a static function
avoids creating the java MockCertVerifier, which saves us a step. I agree we
should change the name of getNativePointer to be more appropriate for this
approach.

+
+    /**
+     * Creates a new net::MockCertVerifier, and returns a pointer to it.
+     * @param certs a String array of certificate filenames in
+     *         net::GetTestCertsDirectory() to accept in testing.
+     */
+    public static long getNativePointer(String[] certs) {

[mef, 2015/10/20 20:43:34]

Given that native cert verifier is not a singleton, would it make sense to name
this something like 'createMockCertVerifier' or 'createNativeVerifier' or
'getNewNativeVerifier' or 'getNativePointerToNewVerifier'?

[xunjieli, 2015/10/20 20:57:26]

Done. createMockCertVerifier sgtm. Agreed, the getNativePointer suggested it is
a singleton which it is not.

+        return nativeCreateMockCertVerifier(certs);
+    }
+
+    private static native long nativeCreateMockCertVerifier(String[] certs);
+}